On Sep 11, 2012, at 4:47 PM, Camillo Bruni wrote: > > On 2012-09-11, at 16:41, Stéphane Ducasse <[email protected]> wrote: > >> camillo >> >> what is "added hierarchical RPackage lookup" ? >> Why do we need that beast? > > Because right now RPackageOrganizer does a wrong lookup for classes > see RPackageOrganizer>>#systemClassRenamedActionFrom: > which does a > #packageNamed: class category > which fails if the class is not in a toplevel package.
I see. and probably class category is not mapped to the correct place. > Let's say I refactor a class TestFoo in the category 'Tests-Foo-Bar' > the message send to #packageNamed: will try to find a package named > 'Tests-Foo-Bar' but the actual existing package is only 'Tests' and > the rest is the tag part. Yes bitten by the pattern shit again. > => you have to find the RPackage with the most common name > lookup? 'Tests-Foo-Bar' => fail! > lookup? 'Tests-Foo' => fail! > lookup? 'Tests' => success! > 'Tests' => lookup tag? 'Foo-Bar' => success! I hate that! Fucking extra complexity. Tx that you fix it. This is exactly what I want to remove. So in Pharo 3.0 I will kill this lookup. Stef
