On Oct 14, 2012, at 1:22 AM, Igor Stasenko wrote:

> An EncryptedMultiDisplayScanner is a MultiDisplayScanner displaying
> stars instead of characters (for password by example)
> 
> Wow... this is soooo overkill!

Indeed I was not aware of that system.

> 
> Look at the amount of extra code we have just to simply displaying
> stupid stars ... ************
> 
> See the:
> EncryptedTextMorphForFieldView>>drawOn:
> ...
> aCanvas encryptedParagraph: self paragraph bounds: fauxBounds color: color.
> 
> ehh?.. Since when canvas (a tool for drawing graphic primitives and
> text) needs to know anything like that?
> 
> I'm not sure if there could be better/simpler solution (considering
> that we don't have a simple line editor and need to go over
> overcomplicated text->composer->scanner->displayscanner chain to be
> able to edit even single string..
> but that's really, really stupid to penetrate multiple layers of
> responsibility just to display stars instead of characters...
> 
> What if i would like to display '%' instead of chars, should i also go
> and repeat same way??
> 
> We should get rid of this thing..

Yes.

> 
> -- 
> Best regards,
> Igor Stasenko.
> 


Reply via email to