On 22 Feb 2013, at 13:08, Sven Van Caekenberghe <[email protected]> wrote:

> On 22 Feb 2013, at 12:13, Sven Van Caekenberghe <[email protected]> wrote:
> 
>> OK, good ;-)
>> 
>> What about the URL ?
>> 
>> It is now
>> 
>>       
>> https://ci.inria.fr/pharo/job/Pharo-2.0/lastSuccessfulBuild/api/xml?xpath=/*/description/text()
>> 
>> it used to be
>> 
>>      
>> https://ci.lille.inria.fr/pharo/job/Pharo-2.0/lastSuccessfulBuild/api/xml?xpath=/*/description/text()
>>      
>> Is this call/URL still possible or has it changed ?
> 
> Without the /text() the URL 
> https://ci.inria.fr/pharo/job/Pharo-2.0/lastSuccessfulBuild/api/xml?xpath=/*/description
>  works, with it there is a security exception:
> 
> $ curl 
> https://ci.inria.fr/pharo/job/Pharo-2.0/lastSuccessfulBuild/api/xml?xpath=/*/description
> <description>2.0 #20563</description>
> 
> $ curl 
> "https://ci.inria.fr/pharo/job/Pharo-2.0/lastSuccessfulBuild/api/xml?xpath=/*/description/text()"
> <html><head><title>Error 403</title></head><body bgcolor="#ffffff"><h1>Status 
> Code: 403</h1>Exception: primitive XPath result sets forbidden; can use 
> -Dhudson.model.Api.INSECURE=true if you run without security<br>Stacktrace: 
> <pre>(none)
> </pre><br><hr size="1" width="90%"><i>Generated by Winstone Servlet Engine 
> v0.9.10 at Fri Feb 22 13:06:16 CET 2013</i></body></html>
> 
> I guess the test can run without /text() unless someone can explain what is 
> going on…

---
Name: Zinc-Zodiac-SvenVanCaekenberghe.25
Author: SvenVanCaekenberghe
Time: 22 February 2013, 3:04:30.18 pm
UUID: b52e2249-16bc-46af-9c11-688fda41ac6d
Ancestors: Zinc-Zodiac-SvenVanCaekenberghe.24

Patch ZnHTTPSTests>>#testGetPharoVersion again because the underlying semantics 
of the URL being tested have changed - no longer use /text() in the XPath query
---

ZnHTTPSTests>>#testGetPharoVersion
        | client lastBuildVersion version |
        self ensureSocketStreamFactory.
        self isNativeSSLPluginPresent ifFalse: [ ^ self ].
        lastBuildVersion := (client := ZnClient new)
                beOneShot;
                get: 
'https://ci.inria.fr/pharo/job/Pharo-2.0/lastSuccessfulBuild/api/xml?xpath=/*/description'.
        self assert: client isSuccess.
        self assert: client response contentType equals: ZnMimeType 
applicationXml.
        self assert: client response contentLength > 0.
        self assert: lastBuildVersion notNil.
        self assert: lastBuildVersion isString.
        self assert: lastBuildVersion size > 0.
        version := (lastBuildVersion copyAfter: $>) copyUpTo: $<.
        self deny: version isEmpty

Over the WE I'll add an issue to update some Zn packages.

>> Sven
>> 
>> On 22 Feb 2013, at 12:07, Camillo Bruni <[email protected]> wrote:
>> 
>>> It is failing (only now?)
>>> 
>>> https://ci.inria.fr/pharo/job/Pharo-2.0-Tests/lastCompletedBuild/testReport/
>>> 
>>> ;)
>>> 
>>> On 2013-02-22, at 12:04, Sven Van Caekenberghe <[email protected]> wrote:
>>> 
>>>> Hi,
>>>> 
>>>> When testing in #20561 I noticed that ZnHTTPSTests>>#testGetPharoVersion 
>>>> consistently fails for me (Mac OS X, NBCog VM), probably because the URL 
>>>> is wrong - this is a function/regression test on 
>>>> https://ci.inria.fr/pharo/job/Pharo-2.0/lastSuccessfulBuild/api/xml?xpath=/*/description/text()
>>>> 
>>>> My point is that I don't see that failing on the CI servers, but maybe I 
>>>> looked in the wrong places.
>>>> 
>>>> The test code does contain a 
>>>> 
>>>>    self isNativeSSLPluginPresent ifFalse: [ ^ self ].
>>>> 
>>>> so it is possible that the test is skipped.
>>>> 
>>>> But if that test is skipped, many more are skipped as well, and that would 
>>>> be not-good™.
>>>> 
>>>> Sven
>>>> 
>>>> --
>>>> Sven Van Caekenberghe
>>>> http://stfx.eu
>>>> Smalltalk is the Red Pill
>>>> 
>>> 
>> 
> 


Reply via email to