Hi Christophe, looks pretty good to me. I did only quick tests. If I find anything I get back to you.
Thanks for your effort. That was one missing piece for me to switch more projects to pharo 2.0 Norbert Am 15.04.2013 um 16:30 schrieb Christophe Demarey <christophe.dema...@inria.fr>: > Hi Norbert, > > I just add a look at your changes. > In my opinion, all stuff related to ConfigurationBaseName shouldn't be > changed. The root of the problem is the Metacello ToolBox version. > I added a new configuration for Versionner (in ss3) for Pharo2. I tested it a > bit and it looks fine. > > What you need : > 1/ Load (don't merge) Metacello-ToolBox-dkh.130 from > http://seaside.gemstone.com/ss/metacello in your Pharo2 image. > 2/ Load ConfigurationOfVersionner from http://ss3.gemstone.com/ss/Versionner > 3/ ConfigurationOfVersionner load > > Let me know if it solves your issues. > > Regards, > Christophe. > > > Le 11 avr. 2013 à 17:40, Christophe Demarey a écrit : > >> Hi Norbert, >> >> Sorry, I don't read Pharo ML every day else I will never have time to work >> on Versionner... I only have a part time to do that. >> What I'm doing on Versionner is to add the possibility to update your >> configurations at a very fine grained (add/remove projects/packages/groups). >> This version is a WIP and not yet usable. I'm not so far to have one version >> open for beta-test but I now face issues with Metacello on Pharo2 and some >> missing API in the toolbox. >> >> That's why I'm now working to have Metacello tests green on Pharo2. >> What I'm doing: >> update builderCi (used by Dale to test Metacello on Travis) to support >> Pharo2/3 : almost done >> be able to load MetacelloPreview on Pharo2/3 >> have green tests. >> >> With a clean and up to date metacello environment for Pharo, I will be able >> to focus on Versionner and have a result soon. >> >> I also did not take time to port the "old" Versionner on Pharo2 since I will >> face the same issues with Metacello/Pharo2. >> The problem is not really Versionner itself but the fact that it relies on >> libraries not tested and not fully working on Pharo2. >> >> I will take a look at your work. (some comments below). >> >> Thanks for your contribution. >> >> Regards, >> Christophe. >> >> >> Le 11 avr. 2013 à 13:18, Norbert Hartl a écrit : >> >>> Huh, I find it strange that nobody cares. Does anybody use Versionner? >>> >>> Norbert >>> >>> >>> Am 09.04.2013 um 11:31 schrieb Norbert Hartl <norb...@hartl.name>: >>> >>>> Yesterday I tried again to use Versionner in 2.0 but did have much >>>> success. So I tried myself (because I think Versionner is important) and >>>> could final generate a new version of my project using versionner. >>>> >>>> Following things I noticed (I'm writing this because I'm not sure which >>>> issue to open for what package. I'm just want opinions and after that I >>>> can open/upload whatever): >>>> >>>> I loaded Versionner from Metacello (taken from [1]) >>>> >>>> Gofer new >>>> url: 'http://ss3.gemstone.com/ss/Versionner'; >>>> package: 'ConfigurationOfVersionner'; >>>> load. >>>> (Smalltalk at: #ConfigurationOfVersionner) perform: #load >>>> >>>> monticello issues >>>> ============= >>>> >>>> While updating the rest of the packages to the newest I saw that >>>> >>>> Versionner-Core-Model-ChristopheDemarey.19 >>>> >>>> has an older ancestor for fixing something for pharo 1.4. The package >>>> >>>> Versionner-Core-Model-ChristopheDemarey.20 >>>> >>>> merged the packages back to HEAD but reverted some things like >>>> SystemAnnouncer back to SystemChangeNotifier. >> >> I tried to switch at a time to Pharo2 but too many issues. So I switched >> back to Pharo1.4 to be able to work on Versionner. >> >>>> So I'm using >>>> >>>> Versionner-Core-Model-ChristopheDemarey.18 >>>> and >>>> Versionner-Core-Commands-ChristopheDemarey.17 >>>> >>>> as older packages. Any other package is the newest in the repository. >> >> I will check that you don't have useless parts of the new Versionner. >> As it is difficult to maintain branches with Monticello, I moved new >> Versionner developments to Smalltalkhub. >> >>>> metacello toolbox issues >>>> ================== >>>> >>>> I don't know much about metacello toolbox but the separation of files into >>>> ConfigurationOf and Baseline seems to have potential for confusion. >> >> ConfigurationOf and Baseline are introduced by newest version of Metacello >> that the one shipped with Pharo2. >> >>>> There is a notion of a basename so it can build ConfigurationOfMyProject >>>> as well as BaselineOfMyProject (MyProject being the basename). But in the >>>> MetacelloToolbox in the pharo2.0 repository it does not seem right. I had >>>> to change the code to use (MBToolbox baseNameOf: …) at a few places. I >>>> took orientation from the message signature. If a method expects a >>>> configurationBaseName and the sender used the configuration class I >>>> changed it. I'll attach the mcz for now to this mail until it is clear >>>> what to do. >> >> What is the version of Metacello and Metacello Toolbox you loaded? >> >>>> versionner issues >>>> ============= >>>> >>>> At one place I added a metacello toolbox name conversion because it made >>>> sense to make it there. The other thing I had to fix is a method >>>> notification that takes the wrong entity from an announcement. >> >> I also fixed that for the new version. >> >>>> Both packages attached as I don't have commit rights and don't know where >>>> the issue tracker for versionner is if there is any) >>>> >>>> I would be glad if any of you guys that know about that stuff could drop >>>> me a note if this is ok or where I've gone wrong. >>>> >>>> thanks, >>>> >>>> Norbert >>>> >>>> >>>> [1] http://users.dcc.uchile.cl/~jsandova/versionner/ >>>> >>>> <Metacello-ToolBox-NorbertHartl.136.mcz> >>>> <Versionner-Core-Commands-NorbertHartl.18.mcz> >>>> <Versionner-Core-Model-NorbertHartl.19.mcz> >>> >> >
