On Mar 18, 2013, at 5:26 PM, LogiqueWerks <[email protected]> wrote:
> so-desu ...
>
> Clicked in don't show message again box ...
>
> But by then I was looking at
>
> (encoding = 'utf-8')
> ifTrue: [^UTF8TextConverter].
>
> (encoding = 'shiftjis' or: [ encoding = 'sjis' ])
>
> as seen in JapaneseEnvironment>>systemConverterClass for X11 ... also looks
> a little fragile for lack of accessors yet X11Encoding is just such a
> class-side location for "utf8EncodingCode" or such like ...
>
> My other programming environment uses "utf8" as the string. Oi vey. Then
> there are the 'UTF-8' folks out there ...
>
> Is there a reason to avoid symbols here ? Or at least to refactor that
>
> () or: []
>
> out and into X11Encoding ?
>
> That call at 2AM on a Sunday morning is Sooo often for similar issues that
> crept past code reviews ... or is this a lighter style that I am used to ?
code quality is very low for most of the old code base…
Improvements are always welcome.
Marcus
