Hi Sven,
Sven,
sorry for my late reply. On the weekends, I try to be away from
Smalltalk. Sometimes I succeed, sometimes I don't ;-)
So first of all, thanks for porting the code and even adding those nice
comments. I like the way "my" code looks now ;-)
About the CRLF stuff: this is a complicated area, even if it looks so
simple. As I mentioned, VAST is not yet Unicode aware, so it adapts
itself to the current platform's line-end conversion. So what I did to
build tests fast was just add line breaks in literals in the test code
and let envy handle the rest. That is, of course, neither a nice coding
convention, nor a perfect solution. I don't know much about Pharo's
handling of line-end conventions of its host platform, so I cannot
comment on the correct way to do this in Pharo.
It is important in VAST to convert to the correct line-endings of the OS
in VAST, and for this VAST provides some pool constants:
CldtConstants::UNIXLineDelimiter and CldtConstants::WinLineDelimiter. As
I understand it, you Pharo guys don't like Pool Dictionaries very
deerly, so I guess there is another place to ask for this if needed.
So in the end, I cannot really judge if your changes are correct. You'd
have to test on both Win and Mac/Linux to see if your changes are
correct. For me, String>>crlf sounds wrong, because it it always returns
both cr and lf. If Pharo also uses the local line-end convention, this
would be wrong in Unix/Mac.
I hope this long version of "I have no idea" is helpful... ;-)
Joachim
Am 06.12.13 20:18, schrieb Sven Van Caekenberghe:
Hi Joachim,
I loaded/copied your code into Pharo 3.0 and made the necessary changes, as
well as some simplifications, to make everything work. See the attached
fileouts.
The tests were almost immediately green.
I have one question though, I had to change two tests to make them work:
#testDecodeCRLF
self
assert: (coder decode: 'This is the first line=0D=0A and this is the
second')
equals: 'This is the first line', String crlf, ' and this is the second’
You originally had a simple line break in the method’s string literal. But that
results in a CR in Pharo. I added an explicit CRLF.
I had to make similar changes to #testEncodeSoftLinebreak.
Is that OK or not ? What do you think ?
Sven
On 06 Dec 2013, at 12:52, Sven Van Caekenberghe <[email protected]> wrote:
Hi Joachim,
The code is perfectly readable, including the German (which I can
read/understand more or less, speaking/writing is quite bad though), thanks a
lot. I will try to port it later today or this evening.
Sven
On 06 Dec 2013, at 12:26, [email protected] wrote:
Hi Sven,
I just see there will be some problems with the test Strings in Pharo. VAST is
not Unicode aware yet, so the fileout of german umlauts and such will very
likely be wrong when pasting into Pharo.
I am happy to send you corrections for the decoded strings in the test code if
your German doesn't suffice. Just tell me which sentences are imported wrong
into Pharo...
I have never tested any other special characters than German ones.
Joachim
Am 06.12.13 12:14, schrieb [email protected]:
Hi Sven,
here you are.
It's possible you get into minor troubles parsing the files, but the code is
short enough to even copy/paste it into Pharo I guess. Since it is a fileout
from VAST, you may need to tweak the categories for monticello and such.
Please let me know if there are problems with the code, if you add new tests or
find bugs. I'd like to add stuff back to my code then.
Good luck,
Joachim
Am 06.12.13 12:06, schrieb Sven Van Caekenberghe:
On 06 Dec 2013, at 12:04, [email protected] wrote:
Hi Sven,
Of course I don't mind. I'll be happy if you find it useful enough to use it in
Pharo.
Great!
The .dat is VAST's proprietary export format for code. So you'd have to install
VAST to get it.
I am not a Pharo contributor yet, so I will see if I can send you a fileout of
the code that should beasier to import into Pharo. I know this is stupid, but I
never worried about the license of such mini-contributions. So if you want,
it's MIT ;-)
Yes, please send some .st files.
Joachim
Am 06.12.13 11:36, schrieb Sven Van Caekenberghe:
Hi Joachim,
On 06 Dec 2013, at 11:22, [email protected] wrote:
Hi Sabine,
this is not of immediate help for you, but I once wrote a QuotedPrintableEncode
for VA Smalltalk. It is in productive use and should handle both encoding and
decoding just fine.
You can find it on vastgoodies.com and I am sure it is not hard to port to
Pharo.
So I guess you are OK with me looking at / porting your code ? Is it MIT
licensed or compatible ? Are you already a signed up Pharo contributor ?
How do you I get at the actual code ?
When doing a download, I get a .dat file. How do I open that ?
Sven
More details:
http://joachimtuchel.wordpress.com/2011/09/23/quotedprintablecoder-on-vastgoodies/
HTH,
Joachim
Am 06.12.13 11:11, schrieb Sabine Knöfel:
Hi Sven,
this would be great.
I need it for sending mails and some mail reader, e.g. Thunderbird on Mac
(Thank you Joachim for reporting this bug :-) ) need this in the subject if
there are special signs in it.
Example:
Subject: =?ISO-8859-1?Q?Kindle_f=FCr_nur_49_EUR?=
Regards
Sabine
On Fri, Dec 6, 2013 at 10:54 AM, Sven Van Caekenberghe-2 [via Smalltalk] <[hidden email]
</user/SendEmail.jtp?type=node&node=4727928&i=0>> wrote:
Yes, indeed
QuotedPrintableMimeConverter>>#mimeEncode is missing.
It shouldn’t be too hard to implement, although it is a bit of a
‘human’ format rather than a technical one.
http://en.wikipedia.org/wiki/Quoted-printable
I’ll see what I can do.
Sven
On 06 Dec 2013, at 09:35, Sabine Knöfel <[hidden email]
<http://user/SendEmail.jtp?type=node&node=4727919&i=0>> wrote:
Hi,
I need this, too.
http://forum.world.st/Issue-4782-Quoted-printable-encoding-incomplete-implementation-td3823737.html
The bug was closed after transferring it to fogbugs:
https://pharo.fogbugz.com/f/cases/4825
Sebastian, may I ask you, how did you solve this?
regards
Sabine
--
View this message in context:
http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895.html
Sent from the Pharo Smalltalk Users mailing list archive at
Nabble.com.
------------------------------------------------------------------------
If you reply to this email, your message will be added to the
discussion below:
http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727919.html
To start a new topic under Pharo Smalltalk Users, email [hidden
email] </user/SendEmail.jtp?type=node&node=4727928&i=1>
To unsubscribe from (MimeConverter forEncoding:
'quoted-printable') subclass responsibility, click here.
NAML
<http://forum.world.st/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
------------------------------------------------------------------------
View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable')
subclass responsibility
<http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4727928.html>
Sent from the Pharo Smalltalk Users mailing list archive
<http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html> at Nabble.com.
--
-----------------------------------------------------------------------
Objektfabrik Joachim Tuchel mailto:[email protected]
Fliederweg 1 http://www.objektfabrik.de
D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
Telefon: +49 7141 56 10 86 0 Fax: +49 7141 56 10 86 1
--
-----------------------------------------------------------------------
Objektfabrik Joachim Tuchel mailto:[email protected]
Fliederweg 1 http://www.objektfabrik.de
D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
Telefon: +49 7141 56 10 86 0 Fax: +49 7141 56 10 86 1
--
-----------------------------------------------------------------------
Objektfabrik Joachim Tuchel mailto:[email protected]
Fliederweg 1 http://www.objektfabrik.de
D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
Telefon: +49 7141 56 10 86 0 Fax: +49 7141 56 10 86 1
--
-----------------------------------------------------------------------
Objektfabrik Joachim Tuchel mailto:[email protected]
Fliederweg 1 http://www.objektfabrik.de
D-71640 Ludwigsburg http://joachimtuchel.wordpress.com
Telefon: +49 7141 56 10 86 0 Fax: +49 7141 56 10 86 1
