I just tried it on my Ubuntu workstation and it appeared to save everything like it should. So it seems specific to the Windows version.

On 6/14/2016 11:37 PM, Bernardo Ezequiel Contreras wrote:
im on debian with
Pharo5.0
Latest update: #50760

i just add a whitespace in the class comment of the class RxParser and then follow your steps, saving the slice locally in a directory.



On Wed, Jun 15, 2016 at 12:08 AM, Mark Bratcher <mdbra...@gmail.com <mailto:mdbra...@gmail.com>> wrote:

    Thanks for trying it. Are you on Windows and Pharo 5.0?

    Can you tell me what item you changed? I'd be curious just to try
    the same thing.


    On 6/14/2016 11:04 PM, Bernardo Ezequiel Contreras wrote:
    i tried your steps locally in a directory with a fake change and
    i couldnt reproduce the bug,  i got the slice and the dependent
    package(with the fake change).
    please report it, someone with more knowledge should check it.



    On Tue, Jun 14, 2016 at 11:54 PM, Mark Bratcher
    <mdbra...@gmail.com <mailto:mdbra...@gmail.com>> wrote:

        Just saving the slice to the repository (as the instructions
        indicate) does not save the code also, and Monticello marks
        the slice and associated packages all clean when just saving
        the slice. So I'm thinking bug...?


        On 6/14/2016 10:38 PM, Bernardo Ezequiel Contreras wrote:
        the slice has no code, it just a reference to the
        dependencies (the dirty packages), those dirty packages
        should be save in the repository(files ended with mcz in
        your directory)
        if you don't have those files in the local
        repository(directory), theres a bug.

        On Tue, Jun 14, 2016 at 11:33 PM, Mark Bratcher
        <mdbra...@gmail.com <mailto:mdbra...@gmail.com>> wrote:

            I opened the MCZ file saved for the slice package and it
            has no code changes in it. It just has the dependency
            information. So it does seem that more has to be saved
            to the repository than just the SLICE. Or, the SLICE
            operation isn't "capturing" the code properly as part of
            the package. In one of my attempts, I did try saving
            both the SLICE and the package independently, but that
            didn't get rid of the error.


            On 6/14/2016 10:23 PM, Bernardo Ezequiel Contreras wrote:
            there's something fishy going on. (the dependency
            wasn't save to the inbox).
            in the other hand, the contribution steps could be improved



            On Tue, Jun 14, 2016 at 11:03 PM, Mark Bratcher
            <mdbra...@gmail.com <mailto:mdbra...@gmail.com>> wrote:

                Bernardo

                Thank you. That's a good idea. I'll try that. I was
                surprised that it didn't go to the inbox as I
                thought I set up the repository path properly.

                Mark

                Sent from TypeApp <http://www.typeapp.com/r>

                On Jun 14, 2016, at 10:00 PM, Bernardo Ezequiel
                Contreras <vonbecm...@gmail.com
                <mailto:vonbecm...@gmail.com>> wrote:

                    i forgot to mention that i used to save my
                    slices locally in a directory, and test the
                    slice with a new image and see if the merge of
                    the slice has no conflicts, to be sure that the
                    monkey will work without problems.
                    and then i copy the slice to the inbox


                    On Tue, Jun 14, 2016 at 10:53 PM, Bernardo
                    Ezequiel Contreras <vonbecm...@gmail.com
                    <mailto:vonbecm...@gmail.com>> wrote:

                        Hi mark,
                         it seems that your
                        package: Regex-Core-MarkBratcher.39.mcz is
                        not the inbox.
                         if you have the package, then you can
                        Copy(button in the monticello browser) it
                        to the inbox, and try again.



                        On Tue, Jun 14, 2016 at 9:53 PM, Mark
                        Bratcher <mdbra...@gmail.com
                        <mailto:mdbra...@gmail.com>> wrote:

                            I am trying to push a simple
                            enhancement to Pharo50inbox on
                            smalltalkhub.com
                            <http://smalltalkhub.com>. I am running
                            Pharo 5.0 (downloaded within the last
                            month) on Windows 10.

                            I started from a completely clean
                            image, made my small change (about 5
                            lines in an existing Pharo 5.0 class),
                            and I followed all of the directions to
                            contribute a proposed fix
                            <http://pharo.org/contribute-propose-fix>
                            very carefully. All the steps went
                            smoothly, as expected, until it came
                            time to pull and verify the slice.

                            Here is a snapshot of my Monticello
                            browser right BEFORE pushing
                            <http://i.stack.imgur.com/Zv2bZ.jpg>
                            the suggested change slice. What is
                            listed as dirty are the SLICE itself
                            (containing Regex-Core
                            (TheIntegrator.38)) and the package
                            itself, listed separately, as dirty
                            (Regex-Core (TheIntegrator.38)).

                            As indicated in the instructions, I
                            highlighted the SLICE and did a Save to
                            the
                            `http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main`
                            repository. That went smoothly. After
                            clicking save, Monticello showed
                            <http://i.stack.imgur.com/BYfVf.jpg>
                            that the SLICE (with subpackage) and
                            the separately listed package were no
                            longer marked dirty and version had
                            been bumped with my name associated
                            (both now called, "Regex-Core
                            (MarkBratcher.39)").

                            The dialog that popped up after the
                            save indicated that there is a
                            dependency on `Regex-Core
                            (MarkBratcher.39)` which surprised me a
                            bit, but since I followed the
                            instructions exactly, I wasn't
                            concerned yet...

                            When I tried to verify, I started with
                            a clean image again (as recommended in
                            the instructions, opened Monticello,
                            opened the Pharo50Inbox repository,
                            found and highlighted my slice, and
                            clicked "Load". Then I got an error
                            that there was a missing dependency on
                            the package: `Regex-Core
                            (MarkBratcher.39)`. I thought that
                            package was integrated as part of the
                            SLICE.

                            If I followed the linked instructions
                            precisely, what am I missing?




-- Bernardo E.C.

                        Sent from a cheap desktop computer in South
                        America.




-- Bernardo E.C.

                    Sent from a cheap desktop computer in South
                    America.




-- Bernardo E.C.

            Sent from a cheap desktop computer in South America.




-- Bernardo E.C.

        Sent from a cheap desktop computer in South America.




-- Bernardo E.C.

    Sent from a cheap desktop computer in South America.




--
Bernardo E.C.

Sent from a cheap desktop computer in South America.

Reply via email to