Andrew, I've tried to comment on the changes. Overall, it was essentially what I was envisioning. My comments on a few methods are mostly specific quibbles about the implementation. One reflects that I think the original implementation contains an error.
Thanks for doing this! On Sun, Oct 1, 2017 at 7:10 AM, Prof. Andrew P. Black <[email protected]> wrote: > Richard (and others): > > Marcus and I committed methods to implement these category tests on > Friday. If any of you have time to review the code, it would be > appreciated. The commit can be found here: > > https://github.com/pharo-project/pharo/pull/326/commits/ > 933b1dcba05b837ab292e19aab413f67b3f9eec5 > > I noticed that there is one test failing — which seems to be entirely > unrelated The test passes in my image. > > Andrew > > >
