and you
get to see the
painting shown
in the
Inspector.
Now if I
understand
your
question...
"Do I need to
make some more
object to get
this
working..."
I'd
say... No. You
only want one
object for
each
painting. Once
you have a
painting
object, it
should handle
all getting
all further
data it needs
for itself.
You don't
want duplicate
objects each
having half of
the data.
can
I for example
name the
function
fromJson2 or
fromJSONFromLink2
?
By naming
convention
#fromJson:
implies it
sits on the
class side.
To get
further data
for an
existing
object you
want an
instance-side
method, maybe
named
#getLink2Json.
HTH,
cheers
-ben
oke
numbers should be the objectNumbers because for the
rest I need them
I use a instance variable called painting to hold the
data.
so I can change the call to get data for the painting
to :
Painting class >> fromJSON: json
| instance |
instance := self new.
instance
objectNumber: ((json at:
#objectNumber).
^ instance
so numbers should be a collection of 10
ObjectNumbers
I'm presuming that 10 objectNumbers relate to 10
different paintings,
in which case, No, you should never need to deal with
a collection of 10 objectNumbers.
What you should have is a collection of
painting-objects which know their own objectNumber
and then iterate that collection sending each
painting-object the message "getLink2Json".
so I should use a loop to make a call to the
second api call
In Pharo OO approach, you don't "loop" on the
"calls",
you "iterate" on the "objects" asking them to use
their own data to do the stuff they know how to do.
i.e. Let each object take care of itself.
Which class is getImages defined on? That is really
important to understand your proposed solution.
I'm just presuming its defined on the class side of
Paintings since your are referring to the same URL as
before.
{"elapsedMilliseconds":27,"artObject":{"links":{"search":"https://www.rijksmuseum.nl/api/nl/collection"},"id":"nl-SK-C-5","priref":"5216","objectNumber":"SK-C-5","language":"nl","title":"Schutters van wijk II onder leiding van kapitein Frans Banninck Cocq, bekend als de ‘Nachtwacht’","tags":[{"userId":3530,"name":"margaret barrett my first collection","lang":"en","objectNumber":"SK-C-5"},// more results...],"copyrightHolder":null,"webImage":{"guid":"92253da1-794d-49f4-9e3c-e4c160715f53","offsetPercentageX":50,"offsetPercentageY":100,"width":2500,"height":2034,"url":"http://lh6.ggpht.com/wwx2vAS9DzFmmyeZefPjMtmCNOdjD80gvkXJcylloy40SiZOhdLHVddEZLBHtymHu53TcvqJLYZfZF7M-uvoMmG_wSI=s0"},"colors":["#261808",// more results...],"colorsWithNormalization":[{"originalHex":"#261808","normalizedHex":"#000000"},// more results...],"normalizedColors":["#000000",// more results...],"normalized32Colors":["#000000",// more results...],"titles":["Officieren en andere schutters van wijk II in Amsterdam onder leiding van kapitein Frans Banninck Cocq en luitenant Willem van Ruytenburch, bekend als de ‘Nachtwacht’","Het korporaalschap van kapitein Frans Banninck Cocq en luitenant Willem van Ruytenburch, bekend als de 'Nachtwacht'"],"description":"Het korporaalschap van kapitein Frans Banninck Cocq en luitenant Willem van Ruytenburch, bekend als de 'Nachtwacht'. Schutters van de kloveniersdoelen uit een poort naar buiten tredend. Op een schild aangebracht naast de poort staan de namen van de afgebeelde personen: Frans Banninck Cocq, heer van purmerlant en Ilpendam, Capiteijn Willem van Ruijtenburch van Vlaerdingen, heer van Vlaerdingen, Lu[ij]tenant, Jan Visscher Cornelisen Vaendrich, Rombout Kemp Sergeant, Reijnier Engelen Sergeant, Barent Harmansen, Jan Adriaensen Keyser, Elbert Willemsen, Jan Clasen Leydeckers, Jan Ockersen, Jan Pietersen bronchorst, Harman Iacobsen wormskerck, Jacob Dircksen de Roy, Jan vander heede, Walich Schellingwou, Jan brugman, Claes van Cruysbergen, Paulus Schoonhoven. De schutters zijn gewapend met lansen, musketten en hellebaarden. Rechts de tamboer met een grote trommel. Tussen de soldaten links staat een meisje met een dode kip om haar middel, rechts een blaffende hond. Linksboven de vaandrig met de uitgestoken vaandel.","labelText":null,"objectTypes":["schilderij"],"objectCollection":["schilderijen"],"makers":[{"name":"Rembrandt Harmensz. van Rijn","unFixedName":"Rembrandt Harmensz. van Rijn","placeOfBirth":"Leiden","dateOfBirth":"1606-07-15","dateOfBirthPrecision":null,"dateOfDeath":"1669-10-08","dateOfDeathPrecision":null,"placeOfDeath":"Amsterdam","occupation":["prentmaker","tekenaar","schilder"],"roles":["schilder"],"nationality":"Noord-Nederlands","biography":null,"productionPlaces":[],"schoolStyles":[],"qualification":null}],"principalMakers":[{"name":"Rembrandt Harmensz. van Rijn","unFixedName":"Rembrandt Harmensz. van Rijn","placeOfBirth":"Leiden","dateOfBirth":"1606-07-15","dateOfBirthPrecision":null,"dateOfDeath":"1669-10-08","dateOfDeathPrecision":null,"placeOfDeath":"Amsterdam","occupation":["prentmaker","tekenaar","schilder"],"roles":["schilder"],"nationality":"Noord-Nederlands","biography":null,"productionPlaces":[],"schoolStyles":[],"qualification":null}],"plaqueDescriptionDutch":"Rembrandts beroemdste en grootste doek werd gemaakt voor de Kloveniersdoelen. Dit was een van de verenigingsgebouwen van de Amsterdamse schutterij, de burgerwacht van de stad. \r\nRembrandt was de eerste die op een groepsportret de figuren in actie weergaf. De kapitein, in het zwart, geeft zijn luitenant opdracht dat de compagnie moet gaan marcheren. De schutters stellen zich op. Met behulp van licht vestigde Rembrandt de aandacht op belangrijke details, zoals het handgebaar van de kapitein en het kleine meisje op de achtergrond. Zij is de mascotte van de schutters.","plaqueDescriptionEnglish":null,"principalMaker":"Rembrandt Harmensz. van Rijn","artistRole":null,"associations":[],"acquisition":{"method":"bruikleen","date":"1808-01-01T00:00:00Z","creditLine":"Bruikleen van de gemeente Amsterdam"},"exhibitions":[],"materials":["doek","olieverf"],"techniques":[],"productionPlaces":[],"dating":{"presentingDate":"ca. 1642","sortingDate":1642,"period":17},"classification":{"iconClassIdentifier":["45(+26)","45C1","48C7341","31D11222","45D12","34B11"],"motifs":[],"events":[],"periods":[],"places":["Amsterdam"],"people":[]},"hasImage":true,"historicalPersons":[],"inscriptions":["Rembrandt f 1642","signatuur en datum","Frans Banning Cocq, heer van purmerlant en Ilpendam, Capiteijn Willem van Ruijtenburch van Vlaerdingen, heer van Vlaerdingen, Lu[ij]tenant, Jan Visscher Cornelisen Vaendrich, Rombout Kemp Sergeant, Reijnier Engelen Sergeant, Barent Harmansen, Jan Adriaensen Keyser, Elbert Willemsen, Jan Clasen Leydeckers, Jan Ockersen, Jan Pietersen bronchorst, Harman Iacobsen wormskerck, Jacob Dircksen de Roy, Jan vander heede, Walich Schellingwou, Jan brugman, Claes van Cruysbergen, Paulus Schoonhoven","inscriptie"],"documentation":["Inzoomer object op zaal, 2013 (Nederlands/English).","A. Jensen Adams, Public Faces and Private Identities in Seventeenth-Century Holland, Portraiture and the Production of Community, New York 2009, p. 211-217, fig. 60.","M. Rayssac, 'l'Exode des Musées, Histoire des oeuvres d'art sous l'Occupation', Parijs 2007.",// more results...],"catRefRPK":[],"principalOrFirstMaker":"Rembrandt Harmensz. van Rijn","dimensions":[{"unit":"cm","type":"hoogte","part":null,"value":"379,5"},{"unit":"cm","type":"breedte","part":null,"value":"453,5"},{"unit":"kg","type":"gewicht","part":null,"value":"337"},{"unit":"kg","type":"gewicht","part":null,"value":"170"}],"physicalProperties":[],"physicalMedium":"olieverf op doek","longTitle":"Schutters van wijk II onder leiding van kapitein Frans Banninck Cocq, bekend als de ‘Nachtwacht’, Rembrandt Harmensz. van Rijn, 1642","subTitle":"h 379,5cm × b 453,5cm × g 337kg","scLabelLine":"Rembrandt Harmensz. van Rijn (15-jul-1606 - 08-okt-1669), 1642, olieverf op doek","label":{"title":"Schutters van wijk II onder leiding van kapitein Frans Banninck Cocq, bekend als de ‘Nachtwacht’","makerLine":"Rembrandt Harmensz van Rijn (1606–1669), olieverf op doek, 1642","description":null,"notes":null,"date":"2013-05-22"},"showImage":true},"artObjectPage":{"id":"nl-sk-c-5","similarPages":[],"lang":"nl","objectNumber":"sk-c-5","tags":[],"plaqueDescription":null,"audioFile1":null,"audioFileLabel1":null,"audioFileLabel2":null,"createdOn":"0001-01-01T00:00:00Z","updatedOn":"0001-01-01T00:00:00Z","adlibOverrides":{"titel":null,"maker":null,"etiketText":null}}
where I at this moment need only artObjects -> makers -> name and artobject -> title
And I need to do that for all 10
But as far as I know I can only have one fromJson so how do I take care that the second one is called and parsed
and the right info is on the Painting object
That is my question all the time
Roelof
