Okay. I consider it still a work in progress (should have stated that). :) I tested it with a simple case "convert !input! -resize '200%' !output!" it seemed to work fine. I admit that submitting concrete test cases with patches would be the right way to go. This way it would easier to see that my expectations of the way the code should work are right and there are less misunderstandings.
I fail to see the issue with regex. As far as I understand re.sub just does a simple replacement operation. Could you provide case in which it fails? I'm not a big fan of the !input/output! syntax. Perhaps there's a better way to sort it out? Originally I tried with <input/output> but it clashes with the current system. Good point about making the input a temporary file! I will replace os.system. I just found subprocess call/check_call yesterday while working on lossless JPEG action. -- Implementation of "Command line action with themporary files or pipes" https://bugs.launchpad.net/bugs/386682 You received this bug notification because you are a member of Phatch Developers, which is subscribed to Phatch. Status in Phatch = Photo & Batch!: Incomplete Bug description: This patch implements https://blueprints.launchpad.net/phatch/+spec/command-line-action . _______________________________________________ Mailing list: https://launchpad.net/~phatch-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~phatch-dev More help : https://help.launchpad.net/ListHelp
