Looks great. I have a few suggestions:
* Since this is all new code, I suggest we use const throughout wherever
sensible (for all @property's, opEquals etc).
* The if isFloatingPoint!T constraint worries me that we won't support
unlimited precision reals or fixed point numbers later. I suggest we
leave the constraint out for now.
* opAssign and opOpAssign should return a ref
Otherwise, this looks great. Good work!
Andrei
On 04/19/2010 04:10 AM, Lars Tandle Kyllingstad wrote:
I've attached a new version of my std.complex proposal to this message.
I can't think of more features to add, so please have a look at it and
tell me what you think. Specifically,
- What's missing?
- Should anything be removed?
- And, importantly, this potentially being my first contribution
to Phobos: Does the code meet Phobos' quality requirements?
If there are no protests, I'll commit it to SVN.
-Lars
_______________________________________________
phobos mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/phobos
_______________________________________________
phobos mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/phobos
