The failing unittests still exit with an errorlevel. The change was to not exit immediately on the assert error, but to remember that it failed, run all the unittests, then exit with errorlevel set to 1 if any of them had failed.

In other words, the unit tests are not being run by the people checking in phobos changes.

I also find the ErrnoException saying "(No error)" is very strange.

BTW, the std.complex failures are possibly due to changes in toString().

Andrei Alexandrescu wrote:
Yup, that has a lot to do with the changes to assert semantics. Prior to those, it was embarrassing for people to check in stuff that broke the build. Now, failing unittests only issue one like to stdout - who cares?

Andrei

Walter Bright wrote:

unittest
std.xml(379): unittest failure
std.complex(514): unittest failure
std.complex(519): unittest failure
The syntax of the command is incorrect.
std.exception.errnoexcept...@std\process.d(327):  (No error)

--- errorlevel 1


_______________________________________________
phobos mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/phobos

Reply via email to