On 5/1/2011 10:51 PM, Andrei Alexandrescu wrote:
David -- you may want to make updates through the pull request system.
That gives you the opportunity of having one extra pair of eyes look
over the code.
Ideally there should be at least two people involved in a change.
Unfortunately, it looks like the second person is me rather often.
I understand the idea that significant commits should be reviewed, but
where do we draw the line? Reviewing even the most trivial commits
seems unnecessarily bureaucratic to me. In the case of the initial
commit, std.parallelism had already been in review for weeks. (To play
Devil's Advocate, though, the changes to the make file might have been
worth reviewing.)
_______________________________________________
phobos mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/phobos
