Re: [phobos] [D-Programming-Language/phobos] a15e68: Accidentally committed with a bunch of debugging c...

Wed, 04 May 2011 08:06:53 -0700 


>________________________________
>From: Andrei Alexandrescu <[email protected]>

>It's difficult to define the "trivial" category. Again, at work we did have 
>the experience that something was considered trivial but caused breakages when 
>deployed. Anyhow, probably we're not at the size we can afford to review each 
>change.


The Phobos community could be huge, and I still wouldn't have time to review 
lots of changes.  I've only reviewed one, and that was because it was a pull 
request changing my code (RedBlackTree).  Not saying that quantity of 
developers doesn't help, but certainly there are other factors.

I'd rather have the pull requests reserved for things that are complex or new, 
and leave small bug fixes to straight commits.  Requiring a review for 
everything is overkill, and actually counterproductive.  Why can't we have 
simple guidelines that can be overridden when needed?  The only hard rule is, 
don't break the build.  If it breaks the build, it needs to be reverted.

-Steve

_______________________________________________
phobos mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/phobos



























					Reply via email to