Are you so sure someone would *always* notice this? This seems like an error
that should be caught by automatic testing (unit test).
I think with reviews, we are looking for subtle or logic errors, not obvious
blow-up ones. This was just a simple mistake, and that
shit happens. I don't think anyone said that people would check in
bug-free code to the master branch.
Note the time between the initial checkin and the fix, this was not a
significant issue.
-Steve
>________________________________
>From: andralex
><reply+c-386425-2aecf1b7f6afda42be20f0fedb55f7b83b33c...@reply.github.com>
>To: [email protected]
>Sent: Tuesday, May 17, 2011 12:49 AM
>Subject: Re: [phobos] Argh, how did I leave that main block in there by
>accident? (de572e9)
>
>The onus is always on the committer to have run the unit tests.
>
>--
>Reply to this email directly or view it on GitHub:
>https://github.com/D-Programming-Language/phobos/commit/de572e9b131d1e66f23886815d9911313995f144#commitcomment-386425
>
>
>
_______________________________________________
phobos mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/phobos
