On 10.06.2011 4:25, Jonathan M Davis wrote:
On 2011-06-09 13:31, Dmitry Olshansky wrote:
Next question in the row - what to do with a mission to swap std.regexp
to std.regex?
Right now, std.file listDir is the only one function in the whole Phobos
that uses std.regexp.
I managed to set it on the std.regex rails, but making soft deprecation
warning appear at the right time without breaking alias listdir
->listDir is a messy thing. Now it seems like a bad idea to update
already deprecated API ;)
So, should I make all of listdir/listDir templated so that they show
deprecation warnings when used?
listdir/listDir is fully templatizable in that I'm not aware of any situation
where having it changed to be templatized would break code. So, ideally it
would have deprecation pragma inside of it, but what we really need is to have
deprecated to be improved such that it can be given a message as well as
whether the deprecation is soft or hard rather than just being hard. If you're
going to mark those functions as scheduled for deprecation, then you can copy
what was done for other functions in std.file - both in the documentation and
with the pragma. The version number of Phobos in the pragma would obviously be
2.054, and the date would probably be October 2011 (normally, it would be
December, but at least one overload of listdir has been listed as going to be
deprecated for a while, and since regexp is on its way out, and we want it out
relatively quickly, 4 months as scheduled for deprecation instead of 6 is
probably plenty for this case).
If you don't want to deal with that though, I can handle it.
No problem, I'll do it.
If I had
understood that all overloads of listdir were supposed to be going away rather
than just the one, I would have scheduled them all for deprecation instead of
renaming the ones I thought that we were keeping, and I guess that I'm the
main person keeping track of the deprecation of stuff at this point. But you
can take care of making the changes if you want to. The chief thing that I was
looking for was for the regexp to regex to be made by someone who is familiar
with regexp and regex.
So it looks like listDir(dir, new RegExp(".*d")) is supposed to be
filter!` !match(a,".*d").empty`(dirEntries(dir));
The problem is that DirIterator won't work with filter... Another is
that DirEntry is not described in docs.
So I guess for now I'll add a regex overload to dirEnitries instead of
listDir.
--
Dmitry Olshansky
_______________________________________________
phobos mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/phobos
