[ 
https://issues.apache.org/jira/browse/PHOTARK-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870015#action_12870015
 ] 

Henry Saputra commented on PHOTARK-20:
--------------------------------------

Some comments:

- Dont forget to add the Apache license header comment to all files.

- The UI for authentication shouldnt be obtrusive with other UI. Meaning that 
we need to support some kind of templating/widget to allow the makrups 
generation for this project to be pluggable. Maybe as SCA widget or as Http 
binding service.

- I kinda agree that Java code for authentication should be separated into 
different maven module.

- The AccessManager.accessLIst has public static modifier but its not protected 
for thread synchronization access.

- Leverage SCA for the server side services.

Hope this helps.

> Integrate OpenId with photark
> -----------------------------
>
>                 Key: PHOTARK-20
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-20
>             Project: PhotArk
>          Issue Type: New Feature
>          Components: PhotArk Admin Services
>    Affects Versions: PhotArk M3
>            Reporter: Avdhesh Yadav
>             Fix For: PhotArk M3
>
>         Attachments: Authentication_improved1.patch
>
>
> Integration of  Open Id with photark.This allows users of popular openids 
> (e.g gmail , yahoo) to use the photark and make the  pictures private...and 
> share albums with some users only..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to