[
https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982693#action_12982693
]
Subash Chaturanga commented on PHOTARK-66:
------------------------------------------
Yes.It is. There is no connection between those two classes. The class I newly
added was org.apache.photark.jcr.services.JCRAlbumAggregator. Both classes
implements the same Album interface. Actually, initially I tried to implement
my album aggregator in org.apache.photark.services.album.AlbumAgregator class.
But due to an interdependency issue, I moved the aggregator to photark-jcr
package. That's what happened. There is no need to have both classes. Both are
same. But as AlbumAgregator class was already there initially, i didn't wanted
to remove it from my patch. So as this is a suggestion for a new structure, I
didn't even touch the old code, I just overloaded all the methods in
JCRGalleryImpl and JCRAlbumImpl with the new functionality and commented at the
beginning of each new method for easy recognition.
> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
> Key: PHOTARK-66
> URL: https://issues.apache.org/jira/browse/PHOTARK-66
> Project: PhotArk
> Issue Type: Improvement
> Environment: Linux
> Reporter: Subash Chaturanga
> Attachments: changedJCRStructure.patch,
> changedJCRStructureUpdate_1.patch, changedJCRStructureUpdate_2.patch,
> Screenshot.png
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of
> local jcr regardless of the album type. Currently photark has basically two
> main album types, local and remote (flicker and picasa). So If the local jcr
> structure is much more organized in trunk such that it stores each album type
> under the relevant category. Hence in future when some more other album
> types introduces it won't be too complex in the jcr level also. And it is
> efficient and fast, when we do jcr operations where we don't need to go
> through the whole album list each time, when we want to acquire all albums of
> one particular type.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
