ID: 15288
Updated by: [EMAIL PROTECTED]
-Summary: Image*-functions being avail even if they're not
implemented by gd
Reported By: [EMAIL PROTECTED]
Status: Open
Bug Type: GD related
Operating System: All
PHP Version: 4.1.1
New Comment:
4.1.2 was only a security fix, and new code only goes to the HEAD
branch. I'll now add your patch to the CVS, the changes will be in PHP
4.2.0.
Derick
Previous Comments:
------------------------------------------------------------------------
[2002-03-02 00:28:27] [EMAIL PROTECTED]
I worry about backward compatibility issues here. I agree that
non-implemented functions should be be defined, but the gd extension I
think was the first ever PHP extension I originally wrote years and
years ago now and it hasn't changed all that much over the years.
I guess the BC issues wouldn't be too bad since the error message was
fatal before so people couldn't really write code to check if the
function was there or not.
------------------------------------------------------------------------
[2002-03-01 22:09:14] [EMAIL PROTECTED]
Did anything happen in this case? Did it just disappear into the magic
night? 4.1.2 still has the same old code in, a small CVS-change for the
TrueColor-functions .. but this (in my mind) broken approach is still
there.
Any reason why it wasnt included?
------------------------------------------------------------------------
[2002-02-02 18:36:19] [EMAIL PROTECTED]
I've also created a patch that remove the functions from the
binary/module (if they're not available);
http://software.e-mats.org/patches/gd.c-diff-2002-02-02
(i also moved this to 'GD related'.)
------------------------------------------------------------------------
[2002-01-30 10:41:52] [EMAIL PROTECTED]
I've made a small patch based on the CVS-version that remove functions
that are not available. I'm not sure if i caught them all, but i made a
try :-) I've not removed the original error-messages ("gd was compiled
without support.."), so they're still in there (maybe a define or
./configure-option to select what way error-reporting should be done).
the diff:
http://software.e-mats.org/patches/gd.c-diff-2002-01-30
the source:
http://software.e-mats.org/patches/gd.c-cvs-2002-01-30
------------------------------------------------------------------------
[2002-01-30 08:51:11] [EMAIL PROTECTED]
I'm +1 on your patch as well, can you make it against the latest CVS
version?
I'll make sure it gets committed then.
regards,
Derick
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://bugs.php.net/15288
--
Edit this bug report at http://bugs.php.net/?id=15288&edit=1
