ID:               14554
 Updated by:       [EMAIL PROTECTED]
 Reported By:      [EMAIL PROTECTED]
 Status:           Closed
 Bug Type:         ZZiplib Related
 Operating System: linux
 PHP Version:      4.1.0
 New Comment:

Guys.. 4.2.0 was released without that fix!


Previous Comments:
------------------------------------------------------------------------

[2001-12-22 20:59:31] [EMAIL PROTECTED]

Applied the patch. Thx !

Derick

------------------------------------------------------------------------

[2001-12-22 18:52:20] [EMAIL PROTECTED]

Also sent to [EMAIL PROTECTED]

> cvs diff -u
cvs server: Diffing .
Index: zip.c
===================================================================
RCS file: /repository/php4/ext/zip/zip.c,v
retrieving revision 1.27
diff -u -r1.27 zip.c
--- zip.c       11 Dec 2001 15:30:57 -0000      1.27
+++ zip.c       22 Dec 2001 23:47:17 -0000
@@ -250,9 +250,10 @@
        zval             *zzip_ent;
        ZZIP_DIR         *archive_p = NULL;
        php_zzip_dirent  *entry = NULL;
-       int               mode;
+       char             *mode;
+       int               mode_len;
 
-       if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rr|l",
&zzip_dp, &zzip_ent, &mode) == FAILURE)
+       if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rr|s",
&zzip_dp, &zzip_ent, &mode, &mode_len) == FAILURE)
                return;
        ZEND_FETCH_RESOURCE(archive_p, ZZIP_DIR *,        &zzip_dp, 
-1, le_zip_dir_name,   le_zip_dir);
        ZEND_FETCH_RESOURCE(entry,     php_zzip_dirent *, &zzip_ent,
-1, le_zip_entry_name, le_zip_entry);


------------------------------------------------------------------------

[2001-12-22 15:44:27] [EMAIL PROTECTED]

Can you send a new patch which fixes that zip_entry_open thingy to
Derick? He'll handle it.

------------------------------------------------------------------------

[2001-12-17 10:31:51] [EMAIL PROTECTED]

It seems to be fixed in the current CVS tree (except for the third
argument to zip_entry_open(), which is optional).

------------------------------------------------------------------------

[2001-12-17 02:44:40] [EMAIL PROTECTED]

Can you send the patch to me by mail? The bugform screwed it up a
little (and please make a patch against the current CVS version).

Regards,
Derick

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
    http://bugs.php.net/14554

-- 
Edit this bug report at http://bugs.php.net/?id=14554&edit=1

Reply via email to