ID: 42987
Updated by: [EMAIL PROTECTED]
Reported By: rick dot martinez at gmail dot com
Status: Assigned
Bug Type: Feature/Change Request
Operating System: *
PHP Version: 5.2.*
Assigned To: johannes
New Comment:
SAPIs don't need much maintaining but still we need to be sure that
somebody cares even in a few years - best would be if the Litespeed guys
agree to maintain it inside the PHP tree.
I didn't review the code, yet but, additionally to Marcus's comments I
saw that some files use another license than PHP License and other refer
to an outdated version. when bundling they should be licensed under the
current PHP License 3.01.
Previous Comments:
------------------------------------------------------------------------
[2007-10-16 18:45:38] rick dot martinez at gmail dot com
Sounds great. I'm not the actual LSAPI maintainer but I'll go ahead and
make the style changes myself and notify the Litespeed developers about
it.
Thanks so much! This will make life SO much easier for so many PHP
users
on Litespeed.
Rick
------------------------------------------------------------------------
[2007-10-16 18:42:13] [EMAIL PROTECTED]
This can imho go into 5.3 and looks pretty good already. You are
however not following our coding standards completely. Read
CODING_STYLE. Especially the following:
- keep { on same line if not beginning of a function or structure
- no // comments allowed
Apart from that you could shorten the code a bit by having /* {{{ */
after the function declaration and not on a separate line when not
adding comments.
As Johannes is the RM for 5.3 he has to decide about this mostly and
finally add the code.
------------------------------------------------------------------------
[2007-10-16 11:13:00] rick dot martinez at gmail dot com
Description:
------------
It would be great if support for the growing Litespeed web server could
be included with PHP. This especially because it's increasingly
difficult for people to support Litespeed with distributions such as
Debian which would require you to completely recompile the PHP deb
packages just to support the server.
I think the server is popular enough to warrant inclusion of their SAPI
into the PHP core. Many people are enjoying it and its popularity is
increasing.
Link to the SAPI:
http://www.litespeedtech.com/packages/lsapi/php-litespeed-4.1.tgz
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=42987&edit=1
