ID:               47695
 User updated by:  p2409 at hotmail dot com
 Reported By:      p2409 at hotmail dot com
 Status:           Closed
 Bug Type:         Compile Failure
 Operating System: Mac OS X 10.5.5
 PHP Version:      5.2.9
 Assigned To:      scottmac
 New Comment:

"[17 Mar 11:49pm UTC] scott...@php.net
AC_MSG_CHECKING([if iconv supports errno])

it's intentionally checking to see if iconv sets errno as well as
returning -1.

This has nothing to do with iconv not building on leopard."


So what got fixed then?


Previous Comments:
------------------------------------------------------------------------

[2009-04-27 18:42:15] j...@php.net

Fixed in all branches now, thanks Scott.

------------------------------------------------------------------------

[2009-04-27 18:35:33] j...@php.net

Not fixed in PHP_5_2 -> re-opened and assigned.

------------------------------------------------------------------------

[2009-04-27 17:49:59] scott...@php.net

This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.

--with-iconv=/opt/local not --with-iconv-dir this is only for xmlrpc
and not for the regular iconv.

------------------------------------------------------------------------

[2009-03-17 23:49:46] scott...@php.net

AC_MSG_CHECKING([if iconv supports errno])

it's intentionally checking to see if iconv sets errno as well as
returning -1.

This has nothing to do with iconv not building on leopard.

------------------------------------------------------------------------

[2009-03-17 18:02:24] p2409 at hotmail dot com

Description:
------------
Many people report problems compiling PHP on Leopard due to a libiconv
issue.

This may be due to the small C test programme in ./configure.
It calls open_conv with two const * char arguments (correct), but these
are NOT valid charsets to iconv (incorrect). This then breaks
./configure.

AFAIK from the libiconv documentation, the PHP ./configure call is
incorrect: this function expects two valid charset arguments. (You can
see a list of valid arguments by running iconv -l).

Changing the call to eg.:

cd = open_conv("UTF-8","ISO-8859-1") 

returns a valid iconv_t number (non-negative), and configure can then
continue setting up for Makefile compile.

Reproduce code:
---------------
In ./configure, search for open_iconv:

cd = open_iconv("*** blah blah ***","*** blah blah ***") 

Expected result:
----------------
This call fails ie. cd return value is negative. ./configure considers
this a libiconv fail, and does not continue.

The expected result is correct ie. -1, however this test should return
a positive number and allow ./configure to continue.

Changing the two parameters in the call to open_iconv to valid charsets
(see list with ./iconv -l) returns a valid translaction number (type
iconv_t). This would then allow ./configure to continue.




------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=47695&edit=1

Reply via email to