ID: 48389 Comment by: duck at hurdfr dot org Reported By: thijs at debian dot org Status: Feedback Bug Type: Compile Failure Operating System: GNU/Hurd PHP Version: 5.2.9 New Comment:
Using the .h files was in order to centralize the code addition, but perhaps i missed part of the include chain and it can be reduced again, sorry. The important thing to know about this bug is that relying unconditionnally on PATH_MAX (and MAXPATHLEN and friends) is an important POSIX incompatibility. On Hurd, there no such limit, then PATH_MAX is not defined at all. So, the perfect patch would be to use dynamic allocation whereas PATH_MAX is undefined and use PATH_MAX if it is, but this would require quite more work. As we are working on inner Hurd code, we do not have time to produce so many long patch for all the non-POSIX-aware code of the world, but this patch is a simple and perfectly working workaround. PHP is an important piece of software, blocking a large amount of other softwares to build/run, so we really do need this fixed. Thanks for your help. Previous Comments: ------------------------------------------------------------------------ [2009-05-25 18:53:00] [email protected] That patch doesn't make much sense to me. You are adding it to php.h and also to files that are already including php.h. And proc_open.c only uses PATH_MAX inside a block of code surrounded by #elif defined(NETWARE) and presumably Hurd does not look like Netware so why are you adding it there? And tsrm_config_common.h already has a check for whether PATH_MAX is defined. We would love to support Hurd, but let's have a cleaner patch. How about posting the build errors from an unpatched PHP build? ------------------------------------------------------------------------ [2009-05-25 18:12:36] thijs at debian dot org Description: ------------ We got a request to make PHP5 on the Hurd operating system. Currently it fails but there's a simple patch that makes it work. Here's the patch to fix the issue, please consider applying it: http://www.a-eskwadraat.nl/~kink/php5_build_hurd.patch ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=48389&edit=1
