ID:               50354
 Updated by:       [email protected]
-Summary:          Syntax inconsistency in function (call & definition)
                   arguments
 Reported By:      jean dot marc dot leger at gmail dot com
-Status:           Open
+Status:           Wont fix
 Bug Type:         Feature/Change Request
 Operating System: Gnu/Linux i686
 PHP Version:      5.2.11
 New Comment:

Trailing commas in function args do not exist in any language and will
not ever exist in PHP either.


Previous Comments:
------------------------------------------------------------------------

[2009-12-01 16:25:15] jean dot marc dot leger at gmail dot com

Description:
------------
PHP has always tolerated one trailing comma (,) at the end of array
declaration, producing no error. I assume this is intended to easily
generate array-syntax compliant php code in a loop.
<?php
/* Array context */
$a = array();          // works fine
// $a = array(,);      // will not work: Parse error: syntax error,
unexpected ',', expecting ')'
$a = array(1,2);       // works fine
$a = array(1,2,);      // works fine : PHP syntax tolerance : last
comma is ignored
//$a = array(1,2,3,,); // will not work: Parse error: syntax error,
unexpected ',', expecting ')'
?>

It would be great to have PHP behaving the same way in function
declaration and function call parameters contexts.

Reproduce code:
---------------
<?php
/* function declaration context */
function myfunction ()     {return true;}    // works
//function myfunction1 (,){return true;}     // will not work: Parse
error: syntax error, unexpected ')', expecting '&' or T_VARIABLE
function myfunction2($a,$b){return true;}    // works
//function myfunction3($a,$b,){return true;} // will not work (should
have): Parse error: syntax error, unexpected ')', expecting '&' or
T_VARIABLE

/* function call context */
myfunction();           // works fine
//myfunction2(,);       // will not work: throws Parse error: syntax
error, unexpected ',', expecting ')'
myfunction3($a,$a);     // works fine
//myfunction4($a,$a,);  // will not work (should have): throws Parse
error: syntax error, unexpected ')'

Expected result:
----------------
<?php
// This declaration shouldn't raise any parse error
function myfunction3($a,$b,){return true;}
// neither does this function call :
myfunction4(1,2,);
// in either cases, the last comma should just be silently ignored by
the parser.

Actual result:
--------------
<?php
function myfunction3($a,$b,){return true;} 
// Parse error: syntax error, unexpected ')', expecting '&' or
T_VARIABLE

myfunction4($a,$a,);  
// Parse error: syntax error, unexpected ')'



------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=50354&edit=1

Reply via email to