ID: 51031 Updated by: johan...@php.net Reported By: geissert at debian dot org -Status: Open +Status: Assigned Bug Type: Strings related Operating System: Debian GNU/Linux ia64 PHP Version: 5.3SVN-2010-02-12 (snap) -Assigned To: +Assigned To: geissert New Comment:
There's no magic to close, just to add comments. Close has to be done by hand. and your account should work. Previous Comments: ------------------------------------------------------------------------ [2010-02-12 21:47:41] ras...@php.net Yes, it accepts many formats. bug #n will work. Also, if the fix applies to multiple active branches, please commit to all branches in a single commit. The active branches are branches/PHP_5_2, branches/PHP_5_3 and trunk ------------------------------------------------------------------------ [2010-02-12 21:38:26] geissert at debian dot org Ok, I just created it. One question: what exactly is the magic to close the bugs from the commit messages? just "\(bug #\d+\)"? ------------------------------------------------------------------------ [2010-02-12 21:17:34] ras...@php.net Could I encourage you to get an svn account and commit some of these trivial fixes yourself? See http://www.php.net/svn.php and click on the "get your own account" link on the left there. ------------------------------------------------------------------------ [2010-02-12 21:08:34] geissert at debian dot org Right, got it: --SKIPIF-- ... if (!setlocale(LC_ALL, 'en_US.UTF-8', 'en')) { ... while the test itself does: setlocale(LC_ALL, 'en-US.UTF-8'); it should use an underscore instead. ------------------------------------------------------------------------ [2010-02-12 21:01:58] ras...@php.net There is no magic here. All we are doing is calling the low-level tolower() function. I bet you can recreate the same thing with this: #include <stdio.h> #include <ctype.h> void main(void) { int ch; for(ch=0; ch<256; ch++) { printf("%x: %x\n",ch,tolower(ch)); } } ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/51031 -- Edit this bug report at http://bugs.php.net/?id=51031&edit=1
