Edit report at http://bugs.php.net/bug.php?id=52063&edit=1

 ID:               52063
 Updated by:       fel...@php.net
 Reported by:      cataphr...@php.net
 Summary:          DateTime constructor's second argument doesn't have a
                   null default value
-Status:           Open
+Status:           Assigned
 Type:             Bug
 Package:          Date/time related
 Operating System: Irrelevant
 PHP Version:      5.3.2
-Assigned To:      
+Assigned To:      derick



Previous Comments:
------------------------------------------------------------------------
[2010-06-12 12:29:03] cataphr...@php.net

Description:
------------
DateTime's constructor is documented like this:



public DateTime::__construct ([ string $time = "now" [, DateTimeZone
$timezone = NULL ]] )



However, not passing the constructor the second argument is not the same
as passing NULL. Fixing this is just a matter of adding a "!", like
this



if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|sO",
&time_str, &time_str_len, &timezone_object, date_ce_timezone)) {



into



if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|sO!",
&time_str, &time_str_len, &timezone_object, date_ce_timezone)) {

Test script:
---------------
<?php



date_default_timezone_set("Europe/Lisbon");

$a = new DateTime("2009-01-01", null);

echo $a->format(DateTime::COOKIE);

Expected result:
----------------
Thursday, 01-Jan-09 00:00:00 WET

Actual result:
--------------
Fatal error: Uncaught exception 'Exception' with message
'DateTime::__construct() expects parameter 2 to be DateTimeZone, null
given' in /tmp/cpCZPA42:4 Stack trace: #0 /tmp/cpCZPA42(4):
DateTime->__construct('2009-01-01', NULL) #1 {main} thrown in
/tmp/cpCZPA42 on line 4


------------------------------------------------------------------------



-- 
Edit this bug report at http://bugs.php.net/bug.php?id=52063&edit=1

Reply via email to