Edit report at http://bugs.php.net/bug.php?id=52407&edit=1
ID: 52407 Comment by: f...@php.net Reported by: eugenesan at gmail dot com Summary: FPM module compilation fails on ARM architecture Status: Assigned Type: Bug Package: Compile Failure Operating System: Linux PHP Version: 5.3.3 Assigned To: fat New Comment: Can you please test & validate this patch on ARM arch ? I've added an #error if ARM && gcc <= 4.2 Previous Comments: ------------------------------------------------------------------------ [2010-07-24 14:36:05] f...@php.net The following patch has been added/updated: Patch Name: fpm_atomic_h_fix.patch Revision: 1279974965 URL: http://bugs.php.net/patch-display.php?bug=52407&patch=fpm_atomic_h_fix.patch&revision=1279974965 ------------------------------------------------------------------------ [2010-07-24 10:38:29] eugenesan at gmail dot com I wasn't aware of atomic functionality in libgcc. In older version of FPM (before W-Mark Kubacki provided current solution), I was copying atomic functions available in libc :-) Also, W-Mark Kubacki tried to propose libatomic as generic solution for all platforms, but due to stability reasons solution was declined. Anyways, provided patch is only for urgent fixing of FPM on ARM in PHP 5.3.3. Later, I would expect more serious treatment of the issue by maintainers. ------------------------------------------------------------------------ [2010-07-24 02:00:20] geiss...@php.net As a matter of fact, why aren't the gcc atomic builtins used in all architectures if gcc > 4.1 is used? Otherwise it is going to be a pain to port the atomic code to many architectures. I've read that icc supports them too, but I don't know since when or anything else. For the Debian packages I'm going to do that, but I'd prefer to see the change happen here too (included a cleanup of the unused atomic_*_t types -- only atomic_t needs to be defined.) ------------------------------------------------------------------------ [2010-07-22 17:30:10] eugenesan at gmail dot com Patch passed heavy load test. ------------------------------------------------------------------------ [2010-07-22 17:21:20] der...@php.net Never mind, it's there now :-) ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/bug.php?id=52407 -- Edit this bug report at http://bugs.php.net/bug.php?id=52407&edit=1
