Edit report at http://bugs.php.net/bug.php?id=49937&edit=1
ID: 49937 Patch added by: basa...@php.net Reported by: basa...@php.net Summary: [PATCH] Race condition in PDOStatement Status: Assigned Type: Bug Package: PDO related Operating System: Linux PHP Version: 5.2.11 Assigned To: basantk Block user comment: N New Comment: The following patch has been added/updated: Patch Name: pdo_race_condition_fix Revision: 1282695197 URL: http://bugs.php.net/patch-display.php?bug=49937&patch=pdo_race_condition_fix&revision=1282695197 Previous Comments: ------------------------------------------------------------------------ [2010-08-24 20:31:38] paj...@php.net Please >attach< the patch to this report, upload it if you prefer. There is a upload field for this exact purpose. Comments are for comments, not for patches (which may loose their text format). ------------------------------------------------------------------------ [2010-08-24 20:17:04] basa...@php.net pajoye, patch is already there in bug log. Look at the patch submitted at 2009- 10-23 16:15 UTC. Http link to the same patch has been provided in comments posted at 2009-11-17 01:51 UTC. I posted the http link of the patch because it makes it easier to commit. (Unfortunately bug database don't have easy way to refer to comments #). ------------------------------------------------------------------------ [2010-08-24 19:38:20] kkaminski at itens dot pl basantk: I used the patch you published in pdo_bug_52trunk.txt (this is complete patch, riight?). The patch fixed my original problem but introduced a new one - in pdo's constructor. As far I understood the code it is something with memory (de)allocation for queryString property. I don't have access to crash dumps at the moment, but I will provide full stack trace tomorrow. ------------------------------------------------------------------------ [2010-08-24 19:24:42] paj...@php.net Can you attach the patch to the report please? Much more easier to follow/review :) ------------------------------------------------------------------------ [2010-08-24 18:45:42] basa...@php.net pajoye, my first patch was a rough patch which used zval_add_ref_atomic. Second patch posted on 2009-11-17 is my final patch. This patch doesn't need any enhancement to php core and it worked for me and several others without crashes. I had tested with iplanet web server on Solaris and Linux and I believe it will work with other multithreaded web servers. Please review the patch posted on 2009-11-17, kkaminski, which patch did you tested. You should test the revised patch submitted on 2009-11-17. Please post the stack trace of the crash if you tested the right patch. Unfortunately php's bug tracker is very primitive in terms of feature. Apache's bug tracker is lot better :-) ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/bug.php?id=49937 -- Edit this bug report at http://bugs.php.net/bug.php?id=49937&edit=1
