Edit report at http://bugs.php.net/bug.php?id=42060&edit=1
ID: 42060 Comment by: jeanseb at au-fil-du dot net Reported by: iarenuno at eteo dot mondragon dot edu Summary: [PATCH] LDAP: Add pagedResults support and more Status: Feedback Type: Feature/Change Request Package: *General Issues Operating System: * PHP Version: 5CVS, 6CVS (2008-11-01) Assigned To: pajoye Block user comment: N New Comment: I have updated the initial patch (php-trunk_ldap-pagination.patch) to reflect this api change and i have integrated the commit of felipe @303159. Tomorrow I'll integrate my review patch (ext-ldap-review.patch) to the initial one and I'll rebuild one, based on trunk. Previous Comments: ------------------------------------------------------------------------ [2010-11-03 13:20:46] paj...@php.net yes, please do, then I can apply the patch to trunk ------------------------------------------------------------------------ [2010-11-03 12:47:59] jeanseb at au-fil-du dot net "resp" means "response" We can rename the API in ldap_control_paged_result & ldap_control_paged_result_response ------------------------------------------------------------------------ [2010-11-03 10:45:02] jeanseb at au-fil-du dot net I used : - openldap-2.3.42-2-vc9-x86.zip - sasl-2.1.23-vc9-x86.zip - openssl-0.9.8k-asm-vc9-x86.zip ------------------------------------------------------------------------ [2010-11-03 10:33:06] paj...@php.net btw, what's the minimum ldap libraries version to be used with this patch? Have you tried ours on Windows? http://pecl2.php.net/downloads/php-windows-builds/php-libs/VC9/x86/ ------------------------------------------------------------------------ [2010-11-03 10:23:48] paj...@php.net I think it can be applied to trunk already. I would not apply it right to 5.3 but wait a bit, to see if this patch works well in trunk 1st. I have however one question, can we use better naming for ldap_ctrl_paged_results_resp? Both "ctrl" and "resp"? It should be control and whatever resp means here. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/bug.php?id=42060 -- Edit this bug report at http://bugs.php.net/bug.php?id=42060&edit=1
