Edit report at http://bugs.php.net/bug.php?id=53328&edit=1
ID: 53328
User updated by: mike at silverorange dot com
Reported by: mike at silverorange dot com
Summary: copy() returns false even if closing the destination
file fails
Status: Open
Type: Bug
Package: Streams related
Operating System: Linux
PHP Version: 5.3.3
Block user comment: N
Private report: N
New Comment:
fflush does correctly return false, but the point of stream wrappers is
to be
able to use the stream functions as I normally would. I normally use
copy to
copy a stream rather than an fopen, fread, fwrite, fflush, fclose loop.
Because of this bug, there's no way to properly detect errors when
copying to
custom streams. In practice, this results in data loss.
I'm fine with the fix going in trunk as afaik php 5.2.x is reaching end
of life
and this is not a security issue.
Previous Comments:
------------------------------------------------------------------------
[2010-11-18 07:52:21] [email protected]
The function you should be testing would be fflush, not copy. fflush
does actually return false.
The flush operation is called for collaterals when closing the file.
copy() should probably return false if closing, at least, the
destination file fails, but it's a risky move because in PHP, for better
or worse, the return value of php_stream_close and friends is almost
always ignored. We'd be giving significance to something that's almost
always ignored.
Maybe for trunk...
------------------------------------------------------------------------
[2010-11-17 16:36:47] mike at silverorange dot com
Till, thanks for making the phpt file. I tested using the phpt and the
raw PHP
file, and both fail as described in the original bug report. This is
using php
5.3.3 as provided by Ubuntu.
I don't see the directory error you describe.
------------------------------------------------------------------------
[2010-11-17 15:43:14] [email protected]
Hey Mike,
I wanted to write a test case but I fail to reproduce this on 5.3.2 so
far.
E.g., I wrapped your code into a phpt, all I get is:
Warning: copy(): The second argument to copy() function cannot be a
directory in
/home/till/test/bug53328.php on line 60
bool(false)
[ On a sidenote, I don't get this error message either. 'foo' is not a
directory, but maybe this means that we have to implement more in the
example
wrapper for it to work, or this is another bug in the streamwrapper?]
Anyway, aside from the weird error message it seems to work indeed on
5.3.2.
Here is your code wrapped in a phpt:
http://friendpaste.com/7Id22SbWNEBnwLhi9FnSTu
Execute with: pear run-tests bug53328.phpt
------------------------------------------------------------------------
[2010-11-17 06:48:23] mike at silverorange dot com
Description:
------------
In a custom stream wrapper if stream_flush() returns false as the
documentation
says it may, parent copy operations do not return false.
Test script:
---------------
http://labs.silverorange.com/files/php-stream-wrapper/test.phps
http://labs.silverorange.com/files/php-stream-wrapper/test.txt
Expected result:
----------------
copy should return false.
Actual result:
--------------
copy returns true.
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/bug.php?id=53328&edit=1
