Edit report at https://bugs.php.net/bug.php?id=55710&edit=1
ID: 55710
Updated by: rquadl...@php.net
Reported by: RQuadling at GMail dot com
Summary: win32 and devel directories not created by makefile.
Status: Open
Type: Bug
Package: *Compile Issues
Operating System: Windows
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
Seems the ADD_FLAG() fix is all that is needed for the win32 directory.
New patch created.
Previous Comments:
------------------------------------------------------------------------
[2011-09-16 12:11:49] RQuadling at GMail dot com
Description:
------------
The win32 and devel directories are only created during configure.js.
If, after a success nmake, the release directory is deleted, the win32 and
devel
directories are not recreated.
win32 and devel is never added to BUILD_DIRS_SUB (via ADD_FLAGS).
Having added "win32" to the build_dirs array initialization, the win32
directory
will still fail to be created in a particular instance.
The ADD_FLAG routine uses indexOf() to determine if "win32" is already part of
the flags. If an extension containing the characters "win32" already exists
(pecl/win32service for example), then the "win32" check will fail and no
"win32"
will be added to BUILD_DIRS_SUB.
The "devel" directory is only added if !MODE_PHPIZE is true. But putting
ADD_FLAG("BUILD_DIRS_SUB", "devel"); in generate_phpize(); is too late as
generate_makefile(); has already been called.
I don't want to do too much with this as I'm not 100% sure, so the additional
test for "devel" has been added in the attached patch.
The supplied patch deals with these issues.
The end result is just that "win32" and, if appropriate "devel" are added to
BUILD_DIRS_SUB so a nmake will always create them if they are missing.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=55710&edit=1
