Edit report at https://bugs.php.net/bug.php?id=14285&edit=1
ID: 14285
Comment by: matt at mattandwell dot net
Reported by: pnh102 at psu dot edu
Summary: Forcing variable declaration
Status: Open
Type: Feature/Change Request
Package: Scripting Engine problem
Operating System: *
PHP Version: *
Block user comment: N
Private report: N
New Comment:
This would be a great option to add in error_reporting, consider the following
script.
ini_set("error_reporting", E_ALL|E_STRICT);
class test1
{
private $m1 = "initial value in t1";
public function setVarsTest()
{
$this->m1 = "in t1";
}
public function showValues()
{
echo(")".$this->m1."(<br/>");
}
}
class test2 extends test1
{
public function setVarsTest()
{
$this->m1 = "in t2";
}
}
$t1 = new test1();
$t1->setVarsTest();
$t1->showValues();
$t2 = new test2();
$t2->setVarsTest();
$t2->showValues();
the output is:
)in t1(
)initial value in t1(
changing $m1 to protected solves the issue, but tracking down issues like this
after a refactoring session could be easier if PHP had this feature.
"$t2->setVarsTest();" would generate a notice in the above code.
Previous Comments:
------------------------------------------------------------------------
[2008-06-13 11:27:34] gvdefence-ncr at yahoo dot it
This feature is necessary in PHP.
Try this simple example:
error_reporting(E_ALL | E_NOTICE | E_STRICT); //E_STRICT for PHP5
class Test
{
var $mispelled_var;
function Test($test)
{
$this->$mispeled_var = $test;
/*
ERROR: we think to instantiate $this->mispelled_var, but
we forgot an 'l' and we are instantiating a new var.
PHP does not raise any error or warning or notice.
*/
}
};
All other languages would raise an error or at least a warning.
I love PHP and I want it to grow, this is a neccesary feature.
It is necessary to add a sort of gobal option that when activated makes PHP
sensible to these type of errors.
------------------------------------------------------------------------
[2004-07-22 09:49:24] jeffrparsons at optushome dot com dot au
I agree this is a very major issue, and it scares people I know away from using
PHP. It would be extremely convenient to have warnings on assignment as well -
instead of just upon reading a non-existent variable - and instead of creating
a variable when a value is first assigned to it, require a separate declaration
using a "var" keyword or such. Obviously not as standard, but as an option...
------------------------------------------------------------------------
[2003-08-13 14:35:52] lsemel at yahoo dot com
This is an important issue. E_ALL doesn't catch everything. It makes PHP
harder to program compared to other languages where you can declare variables
(Perl, Java, etc.)
------------------------------------------------------------------------
[2003-07-16 15:36:44] andrew_nefsky at hotmail dot com
This is definitely an important issue. Not being able to declare variables
creates a debugging nightmare!
------------------------------------------------------------------------
[2002-11-19 08:06:07] z95kahe at mtek dot chalmers dot se
I realy think this is good idea. I've been looking for some tool to do this
kind of checks and found none.
For small scripts there is no need to have variable declaring but there are for
longer multi file, multi developer projects. By making the checks an option we
can have both modes available.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=14285
--
Edit this bug report at https://bugs.php.net/bug.php?id=14285&edit=1
