Edit report at https://bugs.php.net/bug.php?id=60738&edit=1

 ID:                 60738
 Patch added by:     larue...@php.net
 Reported by:        four dot zerooneunauthorized at gmail dot com
 Summary:            Allow 'set_error_handler' to handle NULL
 Status:             Open
 Type:               Feature/Change Request
 Package:            Unknown/Other Function
 Operating System:   irrelivant
 PHP Version:        5.3.9
 Block user comment: N
 Private report:     N

 New Comment:

The following patch has been added/updated:

Patch Name: bug60738.patch
Revision:   1332559920
URL:        
https://bugs.php.net/patch-display.php?bug=60738&patch=bug60738.patch&revision=1332559920


Previous Comments:
------------------------------------------------------------------------
[2012-03-24 03:30:48] larue...@php.net

The following patch has been added/updated:

Patch Name: bug60738.patch
Revision:   1332559848
URL:        
https://bugs.php.net/patch-display.php?bug=60738&patch=bug60738.patch&revision=1332559848

------------------------------------------------------------------------
[2012-03-24 03:26:17] larue...@php.net

Hi, I attached another fix, this will save one alloc/free pair, and also save 
one 
(IS_NULL == Z_TYPE_P(error_handler). 

Nikic,  if you have no objection, I will commit the patch.

thanks

------------------------------------------------------------------------
[2012-03-24 03:24:41] larue...@php.net

The following patch has been added/updated:

Patch Name: bug60738.patch
Revision:   1332559481
URL:        
https://bugs.php.net/patch-display.php?bug=60738&patch=bug60738.patch&revision=1332559481

------------------------------------------------------------------------
[2012-03-23 20:50:45] ni...@php.net

The following patch has been added/updated:

Patch Name: error_handler_patch_1.diff
Revision:   1332535845
URL:        
https://bugs.php.net/patch-display.php?bug=60738&patch=error_handler_patch_1.diff&revision=1332535845

------------------------------------------------------------------------
[2012-03-13 08:56:27] kevin dot swinton at gmail dot com

In the first instance, nothing in here relates to a bug, rather both are 
feature requests.

The first request is for set_error_handler() to function in an identical way to 
set_exception_handler() when called with a single NULL parameter. In the 
interests of a more consistent API this would seem sensible.

The second request is for set_exception_handler() (and by extension 
set_error_handler()) to behave in a different way when called with a single 
NULL parameter.

Given there is no compelling argument, and that such a change could technically 
break BC, and that the request in itself doesn't appear to achieve anything 
useful, the suggestion would be that the first request could be implemented 
whilst the second request has no case.

As a result, I have attached a patch to implement only the first request.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=60738


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=60738&edit=1

Reply via email to