Edit report at https://bugs.php.net/bug.php?id=61787&edit=1
ID: 61787 Updated by: ras...@php.net Reported by: ubuntu at spacetrace dot org Summary: money_format round error Status: Not a bug Type: Bug Package: Math related Operating System: Linux ubuntu 11.04 PHP Version: 5.3.10 Block user comment: N Private report: N New Comment: There is no efficient way to "notice the error" If you want slow and accurate floating point manipulation it is available via the arbitrary precision extensions like bcmath and gmp. Previous Comments: ------------------------------------------------------------------------ [2012-04-22 20:21:49] ubuntu at spacetrace dot org i am sorry, i didnt want to do any harm. i perfectly understood it before already. But what do you think about my suggestions? 1. a notice error or 2. round it like the round() function ------------------------------------------------------------------------ [2012-04-21 22:25:45] ras...@php.net This is getting a bit tiresome. There is no bug here. Maybe you will understand it this way. Try running this: <?php ini_set('precision',32); $ns = array(1.005, 7.005, 8.005); foreach($ns as $n) { echo "$n ".money_format('%.2i', $n)."\n"; } The output on my machine is: 1.004999999999999893418589635985 1.00 7.004999999999999893418589635985 7.00 8.0050000000000007815970093361102 8.01 That is, 1.005 can't actually be represented accurately and it ends up being slightly below 1.005 which means when you round it you get 1.00. And 8.005 ends up being represented as slightly larger than 8.005 so when you round it you get 8.01. It makes perfect sense. Simply add a fuzz factor to your floating point values to the appropriate precision you care about. Or, as most people know, when dealing with money, don't use floating point at all. Work in integers. ------------------------------------------------------------------------ [2012-04-21 21:55:42] ubuntu at spacetrace dot org (i meant: money_format('%.2i',8.005) results in 8.01) ------------------------------------------------------------------------ [2012-04-21 21:54:15] ubuntu at spacetrace dot org money_format('%.2i',1.005) results in 1.00 and money_format('%.2i',7.005) results in 7.01 this is definitely a bug. you only showed me, the reason, how the bug was created. but it should still be solved! Or, if you say, the syntax is not correct, cause you provoke an unpredictable behaviour with '%.2i' then shouldnt that throw an error notice at least? why cannot the php-supporters use the same algorythm, like in function round(), where there IS rounded correctly ------------------------------------------------------------------------ [2012-04-21 21:24:35] ras...@php.net Rounding errors compound when you loop like that. There is still no bug here. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=61787 -- Edit this bug report at https://bugs.php.net/bug.php?id=61787&edit=1