Edit report at https://bugs.php.net/bug.php?id=61421&edit=1
ID: 61421
Comment by: mark at zedwood dot com
Reported by: mark at zedwood dot com
Summary: Missing SHA256,SHA512 families of signature
algorithms
Status: Assigned
Type: Feature/Change Request
Package: OpenSSL related
Operating System: Ubuntu Linux
PHP Version: 5.4.0
Assigned To: pajoye
Block user comment: N
Private report: N
New Comment:
Is there anything preventing this bugfix/patch from being committed into git?
Previous Comments:
------------------------------------------------------------------------
[2012-04-05 22:10:00] mark at zedwood dot com
Changed name of const to OPENSSL_ALGO_RMD160 instead of OPENSSL_ALGO_RIPEMD160
------------------------------------------------------------------------
[2012-04-02 18:21:17] mark at zedwood dot com
added openssl version check, added new patch with .phpt test
------------------------------------------------------------------------
[2012-04-02 09:36:07] [email protected]
hi,
Thanks for the patch, I will apply it asap but it won't make it for the next
releases of 5.3 or 5.4 as we are already in release phases.
Btw, can you add some tests too please?
About the patch, yes, please use the openssl version check instead. As what is
done now won't work smoothly with older versions.
As of getting a svn account (asked per email but adding answer here too), we
usually give one after that one has provided a couple of patches :)
Thanks for your work!
------------------------------------------------------------------------
[2012-04-02 09:21:11] [email protected]
Mark, yes, you probably should. It will also help a lot if you include test
cases for the new functionality. Make sure those tests also run with older
versions of openssl though!
cheers,
Derick
------------------------------------------------------------------------
[2012-03-31 04:00:54] mark at zedwood dot com
should i submit a new patch with
#if OPENSSL_VERSION_NUMBER >= 0x0090708fL
instead of
#ifndef OPENSSL_NO_SHA256
?
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=61421
--
Edit this bug report at https://bugs.php.net/bug.php?id=61421&edit=1
