Edit report at https://bugs.php.net/bug.php?id=62186&edit=1
ID: 62186
Updated by: johan...@php.net
Reported by: sgtbundy at gmail dot com
Summary: readline fails to compile - void function should not
return a value
-Status: Assigned
+Status: Closed
Type: Bug
Package: *Compile Issues
Operating System: SunOS 5.10
PHP Version: 5.4.3
Assigned To: johannes
Block user comment: N
Private report: N
New Comment:
This bug has been fixed in SVN.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
For Windows:
http://windows.php.net/snapshots/
Thank you for the report, and for helping us make PHP better.
Previous Comments:
------------------------------------------------------------------------
[2012-05-30 23:19:47] johan...@php.net
Automatic comment on behalf of johannes
Revision:
http://git.php.net/?p=php-src.git;a=commit;h=428dddd3e8dc8abaf99e22cf6ecf2cff00378fe5
Log: Fix bug #62186 readline fails to compile
------------------------------------------------------------------------
[2012-05-30 06:37:08] sgtbundy at gmail dot com
Description:
------------
Compilation of 5.4 source with readline enabled, using Sun Studio 12 compiler,
fails with this error:
"/var/tmp/php-5.4.3/ext/readline/readline.c", line 201: void function cannot
return value
cc: acomp failed for /var/tmp/php-5.4.3/ext/readline/readline.c
On investigation it seems the info function:
PHP_MINFO_FUNCTION(readline)
Attempts to return a PHP_MINFO value, however comparing the ZEND API function
and other extension source it seems it should be creating an info table instead.
Test script:
---------------
Replacing:
return PHP_MINFO(cli_readline)(ZEND_MODULE_INFO_FUNC_ARGS_PASSTHRU);
With:
php_info_print_table_start();
php_info_print_table_row(2, "Readline library Version",
rl_library_version );
php_info_print_table_end();
Compiles fine
Expected result:
----------------
Successful compilation
Actual result:
--------------
"/var/tmp/php-5.4.3/ext/readline/readline.c", line 201: void function cannot
return value
cc: acomp failed for /var/tmp/php-5.4.3/ext/readline/readline.c
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=62186&edit=1
