Edit report at https://bugs.php.net/bug.php?id=63242&edit=1
ID: 63242
Updated by: larue...@php.net
Reported by: pascal dot chevrel at free dot fr
Summary: Default error page in PHP built-in web server uses
outdated html/css
Status: Open
Type: Feature/Change Request
Package: Built-in web server
Operating System: Linux
PHP Version: 5.4.7
Block user comment: N
Private report: N
New Comment:
I think we can split this into two patch:
1. keep the looks unchanged, and improve the skeleton
2. improve the looks
the first one could easy to be accepted.
Previous Comments:
------------------------------------------------------------------------
[2012-10-09 20:28:56] pascal dot chevrel at free dot fr
btw, I attached a patch to the bug but in case you prefer a Pull Request on
github, just tell me. I don't know what process is preferred today for PHP
patches.
------------------------------------------------------------------------
[2012-10-09 14:50:01] re...@php.net
@Pascal,
I like the idea to make it more modern, I just think the color you choose it
not
well consist with PHP's blue color and visual identity.
------------------------------------------------------------------------
[2012-10-09 12:02:24] pascal dot chevrel at free dot fr
I just attached an updated patch that restores the blue color.
You can see the result here:
http://chevrel.org/images/phpbugs/bug63242v2.png
I also compiled php locally and ran the tests, there were 2 tests failing
because of the new patch, I updated these two tests in my patch.
Tell me if you need updates to this patch, thanks.
------------------------------------------------------------------------
[2012-10-09 09:40:50] pascal dot chevrel at free dot fr
@laruence
Thanks, I will do that this afternoon. Is that ok if I just add back the blue
background color of do you want the page to remain strictly identical to what
it is now? (currently the title and paragraph are not aligned, the title also
has no padding and sticks to the blue border /ex).
------------------------------------------------------------------------
[2012-10-09 09:34:33] larue...@php.net
sorry, should be:
it will be better if you can improve the skeleton, but keep the "looks"
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=63242
--
Edit this bug report at https://bugs.php.net/bug.php?id=63242&edit=1
