ID: 20681
User updated by: [EMAIL PROTECTED]
Reported By: [EMAIL PROTECTED]
Status: Open
Bug Type: Feature/Change Request
Operating System: Win 2K SP3
PHP Version: 4.2.3
New Comment:
Um, actually I was wrong about understanding. The code you posted
contains this line:
$this->value = val;
Which means that all comparisons come out to true. Two of my coworkers
missed this bug too, and so we all thought that comparing objects in
PHP always returned true.
Since objects seem to be compared in a more or less rational fashion,
it seems like array_search() and in_array() should be able to take
objects as the needle. I understand that PHP is only slowly moving
toward being OO (or something like it), but this should at least be
documented.
Also, it should at least be documented that objects cannot be used as
array indices.
Previous Comments:
------------------------------------------------------------------------
[2002-12-05 16:12:48] [EMAIL PROTECTED]
Yes, I understand now. I will be very happy when Zend Engine 2 is
released!
------------------------------------------------------------------------
[2002-11-28 14:02:00] [EMAIL PROTECTED]
My apologies, I should have give more explanation on this.
The following script is nearly an equivalent of array_search().
<?php
function _array_search($needle, $haystack, $strict = false)
{
reset($haystack);
while ((list($key, $element) = each($haystack))) {
if ($strict) {
if ($element === $needle) {
return $key;
}
} else {
if ($element == $needle) {
return $key;
}
}
}
return false;
}
?>
This function actually accepts objects as a needle, but array_search()
doesn't. In this sense, array_search() should go along with objects as
you said.
However IMO it might be too kind to offer this functionality.
<?php
class foo {
var $value;
function foo($val) {
$this->value = val;
}
}
$a = new foo(1);
$b = new foo(2);
$c = $a;
$d = &$a;
var_dump($a == $b);
var_dump($a == $c);
var_dump($a == $d);
var_dump($c == $d);
var_dump($a === $b);
var_dump($a === $c);
var_dump($a === $d);
var_dump($c === $d);
var_dump($a == new foo(1));
var_dump($a == new foo(2));
var_dump($b === new foo(2));
?>
What do you think of the result? Some say this could be preferrable,
but others couldn't.
That's the reason I said the function doesn't need that feature. Isn't
this enough?
------------------------------------------------------------------------
[2002-11-27 14:31:45] [EMAIL PROTECTED]
I don't understand what this has to do with how equality is handled by
the Zend engine. The documentation states that array_search can accept
"mixed" data in the first parameter, which would seem to imply that
objects should work. They don't. Therefore, array_search() is broken.
What am I missing?
Also, I have seen no mention in the PHP manual about how equality is
handled by the Zend engine. Should I file a documentation bug?
Thanks,
Daniel
------------------------------------------------------------------------
[2002-11-27 14:08:01] [EMAIL PROTECTED]
As it's been said enough that identity or equalness of two objects is
somewhat obscure in ZendEngine1, I don't see any reason to implement
this feature unless ZendEngine2 becomes ready for release versions.
So I'm reclassifying this report as a feature request in this point of
view.
------------------------------------------------------------------------
[2002-11-27 11:48:56] [EMAIL PROTECTED]
<?php
class A {
function A () {
}
}
class B {
function B () {
}
}
$g_b = new B ();
$g_array = array (
array ( new A () ),
array ( 'test' ),
array ( $g_b ) );
$g_key = array_search(array ( new A () ), $g_array);
var_dump($g_key);
$g_key = array_search(array ( $g_b ), $g_array);
var_dump($g_key);
$g_key = array_search(array ( 'test' ), $g_array);
var_dump($g_key);
?>
Seems to work as I exect it to:
int(0)
int(2)
int(1)
Also, the original example still produces warnings and doesn't find the
elements if you change the array_search() calls to in_array().
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://bugs.php.net/20681
--
Edit this bug report at http://bugs.php.net/?id=20681&edit=1
