Edit report at https://bugs.php.net/bug.php?id=46408&edit=1
ID: 46408
Updated by: lstro...@php.net
Reported by: alec at smecher dot bc dot ca
Summary: Locale number format settings can cause
pg_query_params to break with numerics
-Status: Wont fix
+Status: Closed
Type: Bug
Package: PostgreSQL related
Operating System: *
PHP Version: 5.*, 6
-Assigned To: yohgaki
+Assigned To: lstrojny
Block user comment: N
Private report: N
New Comment:
The fix for this bug has been committed.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
For Windows:
http://windows.php.net/snapshots/
Thank you for the report, and for helping us make PHP better.
Fixed in 5.5 and master.
Previous Comments:
------------------------------------------------------------------------
[2012-09-06 18:28:55] alec at smecher dot bc dot ca
Pull request filed at https://github.com/php/php-src/pull/186
------------------------------------------------------------------------
[2012-09-06 18:03:28] alec at smecher dot bc dot ca
I suggest this patch.
diff -u -r php-5.4.6/ext/pgsql/pgsql.c php-5.4.6-mod/ext/pgsql/pgsql.c
--- php-5.4.6/ext/pgsql/pgsql.c 2012-08-14 21:26:05.000000000 -0700
+++ php-5.4.6-mod/ext/pgsql/pgsql.c 2012-09-06 10:59:45.000000000 -0700
@@ -23,6 +23,7 @@
/* $Id$ */
#include <stdlib.h>
+#include <locale.h>
#define PHP_PGSQL_PRIVATE 1
@@ -1736,7 +1737,15 @@
} else {
zval tmp_val = **tmp;
zval_copy_ctor(&tmp_val);
+
+ // PSQL requires . for radix; convert to string,
+ // avoiding problems with doubles and locales
+ // using , as a radix character instead
+ // (see https://bugs.php.net/bug.php?id=46408)
+ char *current_locale = setlocale(LC_NUMERIC,
"C");
convert_to_string(&tmp_val);
+ setlocale(LC_NUMERIC, current_locale);
+
if (Z_TYPE(tmp_val) != IS_STRING) {
php_error_docref(NULL TSRMLS_CC,
E_WARNING,"Error converting parameter");
zval_dtor(&tmp_val);
------------------------------------------------------------------------
[2012-04-18 12:44:31] claude dot pache at gmail dot com
@yohgaki (and others)
I think that, the root of the problem is the way PHP uses
the locale information, which I consider deeply broken.
Here are the details:
In my understanding, the locale information is useful only
for *output*, i.e. for messages destined to the user.
They should not be used for any internal conversion
from one type to the other, unless the result is
destined to output.
The problem is, that PHP uses the locale for any
automatic conversion from number to string.
This behaviour is ok in the following case:
echo "Three and a half is: " . $number;
However, in the following cases, this is NOT correct,
because the resulting string must not be localised:
* constructing a JSON object (I hope that json_encode()
does NOT use internal number-to-string conversion);
* using bcmath package (I have personnaly be bitten by
this misfeature);
* construct a SQL request (the present case);
* etc.
In all these cases, you have to do one of the following options:
(1) never use any locale other than en_US
(and re-implement manually the locale feature);
(2) carefully check the type of each and every parameter
and explicitely perform a correct conversion when needed,
e.g. using number_format(..., '.', '');
(3) fix PHP to NOT use locale for number-to-string conversion
unless it is explicitely asked for
(side note: historically, there has been a similar
problem with the "magic quote" misfeature);
(4) modify the modules bcmath, postgresql, etc,
so that they circumvent the mentionned PHP misfeature,
i.e., they do the option (2) above at your place.
In my dreams, the option (3) would be implemented,
but pragmatically, I think that option (4)
has more chance to be implemented rapidly, if ever.
I think that alec asked precisely the option (4) to be implemented.
(Personnally, I have opted for option (1).)
Claude
P.S. The option (4) might seem a non-optimal hack.
However, do not forget that programming languages
and API should be adapted to the needs of the programmers,
and not the other way round.
------------------------------------------------------------------------
[2012-04-18 03:13:12] yohg...@php.net
You misunderstand how libpq/PostgreSQL works.
If you think you can make proper patch for this, clone git source and send pull
request.
No one will stop you from that.
------------------------------------------------------------------------
[2012-04-18 02:58:26] alec at smecher dot bc dot ca
I believe pg_query_params is broken until this is resolved, but it looks like
we're not going to agree on it. I hope someone else can speak up if they do
think this is a bug.
Since we disagree on the approach any patch I write to correct it will be
rejected.
I'll add a comment to the manual page for pg_query_params to document this.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=46408
--
Edit this bug report at https://bugs.php.net/bug.php?id=46408&edit=1
