Edit report at https://bugs.php.net/bug.php?id=65533&edit=1

 ID:                 65533
 Updated by:         johan...@php.net
 Reported by:        fk at florian-kaiser dot net
 Summary:            Unterminated #ifndef in
                     Zend/zend_language_parser.(h|c)
-Status:             Closed
+Status:             Not a bug
 Type:               Bug
 Package:            Compile Failure
 Operating System:   Debian 7
 PHP Version:        5.4.19
 Block user comment: N
 Private report:     N



Previous Comments:
------------------------------------------------------------------------
[2013-08-25 10:25:09] fk at florian-kaiser dot net

I must confess I wasnt thorough enough. You are right, the #endif that closes 
the first #ifndef is at the very last line of zend_language_parser. For some 
reason, I had old zend_language_parser.(h|c) files from the previous debian 
package in the directory that did not get overwritten.

So, I close this bug since it is not a PHP bug at all. Sorry for the the 
inconvenience my lazy research caused.

------------------------------------------------------------------------
[2013-08-23 21:16:03] ahar...@php.net

Those are correct as they are — they're header include guards with matching 
#endif statements at the end of the files. (They're also generated files that 
don't exist in Git.)

How are you compiling this, exactly (ie what commands, are there any additional 
files to do with the packaging, etc)?

------------------------------------------------------------------------
[2013-08-23 11:30:59] fk at florian-kaiser dot net

Description:
------------
When trying to compile the just released version 5.4.19 we get the following 
errors on make:

/tmp/php5.4-5.4.18/Zend/zend_language_parser.h:33:0: error: unterminated #ifndef

[ ... ]

/tmp/php5.4-5.4.18/Zend/zend_language_parser.y:66:0: error: unterminated #ifndef
make[1]: *** [Zend/zend_language_parser.lo] Error 1

The errors itself only seem to turn up using the debian packacking mechanisms, 
not for simple ./configure && make. 

Still, the code clearly suffers from 2 missing closing tags for #ifdef, so I 
guess its not nescessarily reproducable.

I attached a patch that adds both missing endifs.

Expected result:
----------------
Compile finishes without error.

Actual result:
--------------
Compile stops and errors out.


------------------------------------------------------------------------



-- 
Edit this bug report at https://bugs.php.net/bug.php?id=65533&edit=1

Reply via email to