Edit report at https://bugs.php.net/bug.php?id=61759&edit=1
ID: 61759
Comment by: ni...@php.net
Reported by: ahar...@php.net
Summary: class_alias() should accept classes with leading
backslashes
Status: Open
Type: Feature/Change Request
Package: Class/Object related
Operating System: Irrelevant
PHP Version: master-Git-2012-04-18 (Git)
Block user comment: N
Private report: N
New Comment:
I'm not convinced that allowing a leading \ is something we should strive
towards. The \ is unnecessary and redundant (as string names are always fully
qualified). I'd rather allow only the canonical form.
Previous Comments:
------------------------------------------------------------------------
[2013-08-27 12:04:43] jpa...@php.net
Yep, let's start finding all places where classes as strings can be used, and
patch them all to use zend_lookup_class().
There shouldn't be tons of them AFAIR.
------------------------------------------------------------------------
[2013-08-27 10:19:53] contact at jubianchi dot fr
I agree with Johannes about consistency.
The severity is not really is not very high and this use case can easily be
handled at a useland level.
As long as this behavior is not "fixed" I think a warning on the doc shoudl be
enough, even if I'd like to see it fixed (but as I said, it's not a big deal at
the moment).
BTW, thanks for you work Julien :)
------------------------------------------------------------------------
[2013-08-27 10:08:00] johan...@php.net
Technically we could, but it adds some inconsistency if one place allows this
but others not and that should be avoided.
------------------------------------------------------------------------
[2013-08-27 09:46:53] jpa...@php.net
The following patch has been added/updated:
Patch Name: fix-class_alias
Revision: 1377596813
URL:
https://bugs.php.net/patch-display.php?bug=61759&patch=fix-class_alias&revision=1377596813
------------------------------------------------------------------------
[2013-08-27 09:45:12] jpa...@php.net
Johannes: I agree, but we could start by patching this bug report right?
I got a patch here : https://github.com/jpauli/php-
src/compare/class_alias_registration_fix
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=61759
--
Edit this bug report at https://bugs.php.net/bug.php?id=61759&edit=1
