Edit report at https://bugs.php.net/bug.php?id=63255&edit=1

 ID:                 63255
 Updated by:         yohg...@php.net
 Reported by:        pascal dot chevrel at free dot fr
 Summary:            404 page looks amateur
-Status:             Open
+Status:             Closed
 Type:               Feature/Change Request
 Package:            Built-in web server
 Operating System:   all
 PHP Version:        master-Git-2012-10-10 (Git)
-Assigned To:        
+Assigned To:        yohgaki
 Block user comment: N
 Private report:     N

 New Comment:

It seems fixed already.


Previous Comments:
------------------------------------------------------------------------
[2012-11-09 12:36:15] pascal dot chevrel at free dot fr

Can somebody have a look at this simple patch? I saw that 5.4.9RC1 is released 
and I believe it contains my html fix for the 404 page 
(https://bugs.php.net/bug.php?id=63242), it would have been nice to have the 
css part included as well.

------------------------------------------------------------------------
[2012-10-10 15:00:15] pascal dot chevrel at free dot fr

Description:
------------
This is a followup to https://bugs.php.net/bug.php?id=63242 where I provided a 
patch to have html5 syntax and simpler html/css to the 404 page

The 404 page uses styles that were copy/pasted from a 2002 commit for phpinfo 
styling. It looks amateurish, title and text are not aligned, the blue 
background sticks to the title text and it depends partly on the browser 
default html rules, which means that there are differences in display across 
browsers for that page.

I propose a slight change of the css used that will result in something a bit 
leaner while keeping the same blue colour that represents PHP, here is a 
before/after screenshot:
http://chevrel.org/images/phpbugs/bug63242v2_compare.png

This is a simple patch that passes all tests, I will attach it here later today.



------------------------------------------------------------------------



-- 
Edit this bug report at https://bugs.php.net/bug.php?id=63255&edit=1

Reply via email to