ID: 25831
Updated by: [EMAIL PROTECTED]
Reported By: viking at dslnorthwest dot net
Status: Verified
Bug Type: Scripting Engine problem
Operating System: all
PHP Version: 4.3.4RC2-dev
New Comment:
This appears to fix it..
? diff.txt
Index: overload.c
===================================================================
RCS file: /repository/php-src/ext/overload/Attic/overload.c,v
retrieving revision 1.20.2.3
diff -u -r1.20.2.3 overload.c
--- overload.c 15 Apr 2003 04:14:21 -0000 1.20.2.3
+++ overload.c 24 Oct 2003 07:50:15 -0000
@@ -526,7 +526,7 @@
args = (zval ***)emalloc(ZEND_NUM_ARGS() * sizeof(zval **));
- if (zend_get_parameters_array_ex(ZEND_NUM_ARGS(), args) == FAILURE)
{
+ if (zend_get_parameters_array(ht, ZEND_NUM_ARGS(), (zval **)args) ==
FAILURE) {
? diff.txt
Index: overload.c
===================================================================
RCS file: /repository/php-src/ext/overload/Attic/overload.c,v
retrieving revision 1.20.2.3
diff -u -r1.20.2.3 overload.c
--- overload.c 15 Apr 2003 04:14:21 -0000 1.20.2.3
+++ overload.c 24 Oct 2003 07:50:15 -0000
@@ -526,7 +526,7 @@
args = (zval ***)emalloc(ZEND_NUM_ARGS() * sizeof(zval **));
- if (zend_get_parameters_array_ex(ZEND_NUM_ARGS(), args) == FAILURE)
{
+ if (zend_get_parameters_array(ht, ZEND_NUM_ARGS(), (zval **)args) ==
FAILURE) {
efree(args);
php_error(E_WARNING, "unable to obtain arguments");
return;
efree(args);
php_error(E_WARNING, "unable to obtain arguments");
return;
Previous Comments:
------------------------------------------------------------------------
[2003-10-10 22:12:29] [EMAIL PROTECTED]
simple script to reproduce:
<?
class no_problem {
function pass_by_reference(&$ref) {
$ref = "Pass by reference works";
}
}
class problem {
function pass_by_reference(&$ref) {
$ref = "Pass by reference works";
}
// simple dummy call implementation..
function __call($method,$params,&$return) {
if ($method == get_class($this)) {
return true;
}
return false; // not found!
}
}
overload('problem');
$good = &new no_problem;
$bad = &new problem;
$message = "Pass by reference does not work!";
$good->pass_by_reference($message);
print "$message\n";
$message = "Pass by reference does not work!";
$bad->pass_by_reference($message);
print "$message\n";
?>
should print
Pass by reference works
Pass by reference works
actually prints
Pass by reference works
Pass by reference does not work!
------------------------------------------------------------------------
[2003-10-10 19:30:28] viking at dslnorthwest dot net
Description:
------------
When extending the DB_DataObject class using PHP 4.3.3,
pass-by-reference calls to class methods don't work.
After removing the call to overload() at the bottom of
DB_DataObject.php, references work as expected. The
following comments at the bottom of DB_DataObject
allude to this:
// technially 4.3.2RC1 was broken!!
// looks like 4.3.3 may have problems too....
if ((phpversion() != '4.3.2-RC1') && (version_compare(
phpversion(), "4.3.1") > 0)) {
overload('DB_DataObject');
$GLOBALS['_DB_DATAOBJECT']['OVERLOADED'] = true;
}
Reproduce code:
---------------
require_once("DB/DataObject.php");
class no_problem
{
function pass_by_reference(&$ref)
{
$ref = "Pass by reference works";
}
}
class problem extends DB_DataObject
{
function pass_by_reference(&$ref)
{
$ref = "Pass by reference works";
}
}
$good = &new no_problem();
$bad = &new problem();
$message = "Pass by reference does not work!";
$good->pass_by_reference($message);
print "$message\n";
$message = "Pass by reference does not work!";
$bad->pass_by_reference($message);
print "$message\n";
Expected result:
----------------
Pass by reference works
Pass by reference works
Actual result:
--------------
Pass by reference works
Pass by reference does not work!
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=25831&edit=1
