ID: 27293 Updated by: [EMAIL PROTECTED] Reported By: nunoplopes at sapo dot pt -Status: Open +Status: Closed Bug Type: GD related Operating System: Win XP PHP Version: 5CVS New Comment:
This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2004-02-21 05:41:37] [EMAIL PROTECTED] Iliaa has already fixed the first part of the bug (segfaults), but the source needs another change. The proto (and the documentation) state that the threshold is optional. And this is right. If thresold wasn't optional, you should have to call this function like this: image2wbmp($resource, '', 0); It doesn't make any sense. Why not change the default value to a legal one? Please consider my patch. ------------------------------------------------------------------------ [2004-02-21 02:52:43] [EMAIL PROTECTED] Not anymore. ------------------------------------------------------------------------ [2004-02-20 15:09:50] [EMAIL PROTECTED] from gc.c: /* {{{ proto bool image2wbmp(resource im [, string filename [, int threshold]]) Output WBMP image to browser or file */ PHP_FUNCTION(image2wbmp) So thresold is optional. ------------------------------------------------------------------------ [2004-02-19 19:24:37] [EMAIL PROTECTED] Thank you for taking the time to write to us, but this is not a bug. Please double-check the documentation available at http://www.php.net/manual/ and the instructions on how to report a bug at http://bugs.php.net/how-to-report.php You need to pass threshold as the 3rd parameter to image2wbmp() function. ------------------------------------------------------------------------ [2004-02-19 09:58:42] [EMAIL PROTECTED] Using latest snapshot, it doesn't segfault, but it generates a warning: "Warning: image2wbmp(): Invalid threshold value '-1'. It must be between 0 and 255 in c:\nuno\testing\a.php on line 7" ---------- I'm not a developper, but I think this patch solves the problem: cvs diff: Diffing . Index: gd.c =================================================================== RCS file: /repository/php-src/ext/gd/gd.c,v retrieving revision 1.286 diff -u -r1.286 gd.c --- gd.c 17 Feb 2004 21:30:00 -0000 1.286 +++ gd.c 19 Feb 2004 14:58:49 -0000 @@ -1682,7 +1682,7 @@ char *fn = NULL; FILE *fp; int argc = ZEND_NUM_ARGS(); - int q = -1, i, t = 1; + int q = 0, i, t = 1; /* The quality parameter for Wbmp stands for the threshold when called from image2wbmp() */ /* When called from imagewbmp() the quality parameter stands for the for eground color. Default: black. */ ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/27293 -- Edit this bug report at http://bugs.php.net/?id=27293&edit=1
