ID: 28193 Comment by: djpenton at cs dot mu dot oz dot au Reported By: hakan at lisas dot de Status: Open Bug Type: Compile Failure Operating System: Solaris 9 PHP Version: 5.0.0RC2 Assigned To: wez New Comment:
For some reason these: #include <fcntl.h> #include <sys/termios.h> have to be before these: #define _XOPEN_SOURCE and #define _BSD_SOURCE gets around this compile problem: A quick skim of the source of fcntl & termios show that they check for XOPEN... Haven't got time to see what they do with it. Cheers, Dave Previous Comments: ------------------------------------------------------------------------ [2004-04-28 22:54:30] pds+php at alloy dot net In ext/standard/proc_open.c, adding the following lines before #define _XOPEN_SOURCE and #define _BSD_SOURCE gets around this compile problem: #include <fcntl.h> #include <sys/termios.h> ------------------------------------------------------------------------ [2004-04-28 09:38:30] [EMAIL PROTECTED] Ah, I misread your comment. I'll look into fixing this as soon as I am able. If someone who actually has a Solaris 9 box wants to take a look, a patch would be welcome--it's almost certainly a trivial fix if you know what to define. ------------------------------------------------------------------------ [2004-04-28 00:12:29] hakan at lisas dot de with rev 1.20 of ext/standard/proc_open.c it builds just fine. rev 1.21 breaks the build like stated. ------------------------------------------------------------------------ [2004-04-28 00:03:24] [EMAIL PROTECTED] What breaks when building with rev 1.20 of that file? ------------------------------------------------------------------------ [2004-04-27 23:52:38] hakan at lisas dot de The actuall HEAD with ext/standard/proc_open.c 1.20 (not 1.21) does compile. I have no clue about the pty support on Solaris. Some things are defined in /usr/include/fcntl.h and http://gcc.gnu.org/ml/gcc-patches/2000-09/msg00578.html says: AC_DEFINE(_XOPEN_SOURCE, 1, [Always define this]) But I even don't know for what pty-support should be good for :) bye Hakan ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/28193 -- Edit this bug report at http://bugs.php.net/?id=28193&edit=1
