From:             php-bugs at demark dot org
Operating system: Linux
PHP version:      5.0.3
PHP Bug Type:     *General Issues
Bug description:  date_sunrise/date_sunset timestamp calculation bug

Description:
------------
Line 207 of ext/standard/sunfuncs.c is:

RETURN_LONG((int) (time - (time % (24 * 3600))) + (int) 
(60 * ret));

since 'ret' is a double representing the number of hours 
since midnight the sun event occurred and 'time' is in 
seconds, the last multiplier should be number of 
seconds in an hour, not number of minutes in a hour:

RETURN_LONG((int) (time - (time % (24 * 3600))) + (int) 
(3600 * ret));

or, if you want to save one arithmetic step:

RETURN_LONG((int) (time - (time % 86400)) + (int) 
(3600 * ret));

This is also the cause of Bug�#30745.


-- 
Edit bug report at http://bugs.php.net/?id=31853&edit=1
-- 
Try a CVS snapshot (php4):   http://bugs.php.net/fix.php?id=31853&r=trysnapshot4
Try a CVS snapshot (php5.0): 
http://bugs.php.net/fix.php?id=31853&r=trysnapshot50
Try a CVS snapshot (php5.1): 
http://bugs.php.net/fix.php?id=31853&r=trysnapshot51
Fixed in CVS:                http://bugs.php.net/fix.php?id=31853&r=fixedcvs
Fixed in release:            http://bugs.php.net/fix.php?id=31853&r=alreadyfixed
Need backtrace:              http://bugs.php.net/fix.php?id=31853&r=needtrace
Need Reproduce Script:       http://bugs.php.net/fix.php?id=31853&r=needscript
Try newer version:           http://bugs.php.net/fix.php?id=31853&r=oldversion
Not developer issue:         http://bugs.php.net/fix.php?id=31853&r=support
Expected behavior:           http://bugs.php.net/fix.php?id=31853&r=notwrong
Not enough info:             
http://bugs.php.net/fix.php?id=31853&r=notenoughinfo
Submitted twice:             
http://bugs.php.net/fix.php?id=31853&r=submittedtwice
register_globals:            http://bugs.php.net/fix.php?id=31853&r=globals
PHP 3 support discontinued:  http://bugs.php.net/fix.php?id=31853&r=php3
Daylight Savings:            http://bugs.php.net/fix.php?id=31853&r=dst
IIS Stability:               http://bugs.php.net/fix.php?id=31853&r=isapi
Install GNU Sed:             http://bugs.php.net/fix.php?id=31853&r=gnused
Floating point limitations:  http://bugs.php.net/fix.php?id=31853&r=float
No Zend Extensions:          http://bugs.php.net/fix.php?id=31853&r=nozend
MySQL Configuration Error:   http://bugs.php.net/fix.php?id=31853&r=mysqlcfg

Reply via email to