From:             to2958 at sbc dot com
Operating system: AIX 4.3.3
PHP version:      5CVS-2005-12-14 (snap)
PHP Bug Type:     XML related
Bug description:  xmlwriter has non-ansi comments

Description:
------------
I obtained the snapshot 200512141330 to see about other problems and run
into a new problem with compiling the ext/xmlwriter.c. It doesn't look
like that was even part of the stable 5.1.1. I'm running with VAC 4.4.0.3.
I got this on make:
"/store/php5.1-200512141330/TSRM/tsrm_config_common.h", line 23.1:
1506-224 (I) 
Incorrect #pragma ignored.
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1633.17:
1506-0
46 (S) Syntax error.
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1633.26:
1506-0
45 (S) Undeclared identifier not.
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1643.9:
1506-27
6 (S) Syntax error: possible missing 'while'?
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1663.9:
1506-27
6 (S) Syntax error: possible missing 'while'?
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1670.9:
1506-27
6 (S) Syntax error: possible missing 'while'?
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1684.1:
1506-27
6 (S) Syntax error: possible missing 'while'?
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1702.17:
1506-0
46 (S) Syntax error.
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1702.57:
1506-0
45 (S) Undeclared identifier xmlwriter.
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1714.9:
1506-27
6 (S) Syntax error: possible missing 'while'?
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1720.9:
1506-27
6 (S) Syntax error: possible missing 'while'?
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1735.1:
1506-27
6 (S) Syntax error: possible missing 'while'?
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1769.21:
1506-0
45 (S) Undeclared identifier force_string.
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1790.1:
1506-27
6 (S) Syntax error: possible missing 'while'?
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1798.1:
1506-27
6 (S) Syntax error: possible missing 'while'?
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1806.1:
1506-27
6 (S) Syntax error: possible missing 'while'?
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1812.93:
1506-0
45 (S) Undeclared identifier module_number.
"/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1821.16:
1506-0
68 (S) Operation between types "void" and "int" is not allowed.
make: 1254-004 The error code from the last command is 1.

It looks like the comment of // is causing problems a patch is included.

This is similiar to other bugs except none are for this file. Mentioned
bugs are 1424, 8345, 1267. 

Reproduce code:
---------------
Patch:
--- php_xmlwriter.c.orig        Wed Dec 14 10:15:16 2005
+++ php_xmlwriter.c     Wed Dec 14 10:27:23 2005
@@ -1630,7 +1630,7 @@
 
 #ifdef ZEND_ENGINE_2
        if (this) {
-               // We do not use XMLWRITER_FROM_OBJECT, xmlwriter init
function 
here
+               /* We do not use XMLWRITER_FROM_OBJECT, xmlwriter init
function 
here */
                ze_obj = (ze_xmlwriter_object*)
zend_object_store_get_object(thi
s TSRMLS_CC); 
        }
 #endif
@@ -1699,7 +1699,7 @@
 
 #ifdef ZEND_ENGINE_2
        if (this) {
-               // We do not use XMLWRITER_FROM_OBJECT, xmlwriter init
function 
here
+               /* We do not use XMLWRITER_FROM_OBJECT, xmlwriter init
function 
here */
                ze_obj = (ze_xmlwriter_object*)
zend_object_store_get_object(thi
s TSRMLS_CC); 
        }
 #endif


Expected result:
----------------
I expected it to compile everything.


-- 
Edit bug report at http://bugs.php.net/?id=35681&edit=1
-- 
Try a CVS snapshot (PHP 4.4): 
http://bugs.php.net/fix.php?id=35681&r=trysnapshot44
Try a CVS snapshot (PHP 5.1): 
http://bugs.php.net/fix.php?id=35681&r=trysnapshot51
Try a CVS snapshot (PHP 6.0): 
http://bugs.php.net/fix.php?id=35681&r=trysnapshot60
Fixed in CVS:                 http://bugs.php.net/fix.php?id=35681&r=fixedcvs
Fixed in release:             
http://bugs.php.net/fix.php?id=35681&r=alreadyfixed
Need backtrace:               http://bugs.php.net/fix.php?id=35681&r=needtrace
Need Reproduce Script:        http://bugs.php.net/fix.php?id=35681&r=needscript
Try newer version:            http://bugs.php.net/fix.php?id=35681&r=oldversion
Not developer issue:          http://bugs.php.net/fix.php?id=35681&r=support
Expected behavior:            http://bugs.php.net/fix.php?id=35681&r=notwrong
Not enough info:              
http://bugs.php.net/fix.php?id=35681&r=notenoughinfo
Submitted twice:              
http://bugs.php.net/fix.php?id=35681&r=submittedtwice
register_globals:             http://bugs.php.net/fix.php?id=35681&r=globals
PHP 3 support discontinued:   http://bugs.php.net/fix.php?id=35681&r=php3
Daylight Savings:             http://bugs.php.net/fix.php?id=35681&r=dst
IIS Stability:                http://bugs.php.net/fix.php?id=35681&r=isapi
Install GNU Sed:              http://bugs.php.net/fix.php?id=35681&r=gnused
Floating point limitations:   http://bugs.php.net/fix.php?id=35681&r=float
No Zend Extensions:           http://bugs.php.net/fix.php?id=35681&r=nozend
MySQL Configuration Error:    http://bugs.php.net/fix.php?id=35681&r=mysqlcfg

Reply via email to