ID: 36103 Updated by: [EMAIL PROTECTED] Reported By: rebe at unit01 dot net -Status: Open +Status: Assigned Bug Type: FTP related Operating System: linux PHP Version: 5.1.2 Assigned To: tony2001 New Comment:
Tony, don't forget bugs. Again.Linux 2.6.11 Previous Comments: ------------------------------------------------------------------------ [2006-02-22 01:51:57] rebe at unit01 dot net OK, so while i am little but less busy i checked everything again and it looks like both of patches solving problem while connecting to some ftp servers but not everywhere. I am not very clever with that network knowledge but i guess it is still something about blocking/nonblocking sockets. Whole mess i produced before, that one patch is working and second not was about different ftp servers i checked. Now i have my own ftp server configured and TLS is required on it connect. I checked again with lftp client and it's working. Started again from scratch to compile PHP 5.1.2 (./configure --with-apxs --enable-ftp --enable-pcntl --with-mysql --enable-sockets --with-openssl) With Tony's patch and got that: ---------------------------------------------- Warning: ftp_login(): SSL/TLS handshake failed in /root/ftptest.php on line 5 Warning: ftp_login(): AUTH TLS successful in /root/ftptest.php on line 5 login failed ---------------------------------------------- With my patch: ---------------------------------------------- Segmentation fault ---------------------------------------------- So, if i can help anyhow to give you more info (i.e. strace or something) let me know. I still really need to get this work. ------------------------------------------------------------------------ [2006-01-30 08:52:20] [EMAIL PROTECTED] >OK, so looks like your patch is also working properly. Sorry, I didn't get that. Does my patch work without any modifications? ------------------------------------------------------------------------ [2006-01-27 22:03:06] rebe at unit01 dot net OK, so looks like your patch is also working properly. Just give me a couple of days - maybe 'till the middle of the next week to check everything again because I am a little bit busy now doing different work. I want to really confirm that this is a final sollution, so you could apply that patch into official PHP release. It is my first subbmission and I am glad to have really active and collaborating PHP development team :) ------------------------------------------------------------------------ [2006-01-24 10:50:40] [EMAIL PROTECTED] >Frankly - your patch is doing 99% percent the same thing Yes, it does. >}while(errcode == 0 && !SSL_is_init_finished(ftp-ssl_handle)); >we didn't use that in our fix. So does it work without that check? ------------------------------------------------------------------------ [2006-01-24 10:44:57] rebe at unit01 dot net Frankly - your patch is doing 99% percent the same thing but is not fixing problem :) I checked that twice cause I didn't believe it but still getting "handshake failed". The only difference I see is : }while(errcode == 0 && !SSL_is_init_finished(ftp-ssl_handle)); ^^^^^^^^^^^^^^ we didn't use that in our fix. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/36103 -- Edit this bug report at http://bugs.php.net/?id=36103&edit=1