ID: 37168 Updated by: [EMAIL PROTECTED] Reported By: dolecek at sky dot cz -Status: Open +Status: Feedback Bug Type: WDDX related Operating System: NetBSD PHP Version: 5.1.2 New Comment:
I tried your patch on linux 2.6 and MacOSX 10.3.4 and in both cases had no visible difference (beyond the margin of error) in terms of speed and time taken to execute the code. Previous Comments: ------------------------------------------------------------------------ [2006-04-23 21:32:41] dolecek at sky dot cz Also, it would be useful to know if my patch improves performance on your system (even though the time increase is linear even without my patch on your system). Could you include results without and with patch on your system, please? ------------------------------------------------------------------------ [2006-04-23 21:29:43] dolecek at sky dot cz I tried the snapshot php5.1-200604232030 - results: NetBSD 3.99.15 (compiled with ./configure --enable-wddx --with-libxml-dir=/usr/pkg): 50: 0.010740995407104 100: 0.053707838058472 200: 0.23849892616272 400: 2.4622600078583 800: 18.556435823441 1600: 94.584519863129 (3200 and 6400 skipped) Tried also Windows version on Windows XP (same computer): 50: 0.0027320384979248 100: 0.0066189765930176 200: 0.024183988571167 400: 0.096118927001953 800: 0.57651996612549 1600: 2.4123661518097 3200: 8.9470641613007 6400: 34.234342098236 So PHP snapshot is ever worse on NetBSD 3.99.15 then PHP 5.1.2. On Windows XP, the increase is linear, but the time increase is non-proportional (2x size means ~4x time increase). What OS did you try the test? Older BSD malloc() was power-of-2 internally and thus would not suffer from this usage pattern. The more modern version used on NetBSD has been adjusted to minimize total memory use, which gives the realloc() performance hit in this case. Perhaps modern GNU libc malloc()/realloc() handles this usage pattern better and that is the reason you don't see the problem? BTW, if the patch 2) or it's variant is adopted, it would be useful to use some suitable power-of-2 value for SMART_STR_START_SIZE (to get multiple of page size and optimal memory use of last page), rather then changing SMART_STR_PREALLOC (which is unused in my patch). ------------------------------------------------------------------------ [2006-04-23 16:36:39] [EMAIL PROTECTED] Please try using this CVS snapshot: http://snaps.php.net/php5.1-latest.tar.gz For Windows: http://snaps.php.net/win32/php5.1-win32-latest.zip I've tried your sample code and I see only linear increase in the execution time. And certainly at no point did it take seconds to execute each block. ------------------------------------------------------------------------ [2006-04-22 18:42:15] dolecek at sky dot cz It's a minimal intrusion patch, designed to pinpoint and show the problem - feel free to integrate whatever way is best for PHP project. ------------------------------------------------------------------------ [2006-04-22 17:55:03] [EMAIL PROTECTED] The patch is definitely wrong, as this is just a hack overriding functions in this particular case only. Fix the original functions instead (if there are any problems). ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/37168 -- Edit this bug report at http://bugs.php.net/?id=37168&edit=1
