ID:               39192
 Updated by:       [EMAIL PROTECTED]
 Reported By:      ormandj at corenode dot com
-Status:           Assigned
+Status:           Closed
 Bug Type:         iPlanet related
 Operating System: Solaris 10 6/06
 PHP Version:      5.1.6
 Assigned To:      thetaphi
 New Comment:

This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.

I get rid of the weired variable names in config.m4 and made the
creation of the NSAPI_INCLUDE variable more clear. The problem was that
the -I was missing when having the 3.x/7.0 style.
It is fixed in 5_2 and HEAD. Please try the latest 5.2 snapshot! I hope
that the fix is in PHP 5.2.0 final, so we could say, that PHP 5.2 is
compatible with Sun 7.0 webserver.
Not tested until now is compiling with an 64bit variant of the
webserver. Please test this and tell me the needed CFLAGS and
modifications.
I will install SJSWS 7.0 when I have time and test 64bit and will
possibly announce full suport from PHP 5.2.1 on...


Previous Comments:
------------------------------------------------------------------------

[2006-10-26 09:48:58] [EMAIL PROTECTED]

I will look for it and include the configure changes into PHP. I missed
the bug because it was assigned to compile failure not iPlanet (we
should change this bug category to something more modern).
At this time I do not have a Sun 7 server running, so I will have to
install one first.
Another thing is 64 bit compatibility that I want to test.

------------------------------------------------------------------------

[2006-10-26 06:18:41] elving at sun dot com

The problem appears to be due to an incomplete fix for #19290. The
following diff against 5.1.6 works here:

--- sapi/nsapi/config.m4        Wed Oct 25 22:44:33 2006
+++ /home/elving/39192/php-5.1.6/sapi/nsapi/config.m4   Wed Oct 25
23:14:16 2006
@@ -6,3 +6,3 @@
 AC_ARG_WITH(nsapi,
-[  --with-nsapi=DIR        Build PHP as NSAPI module for
Netscape/iPlanet/SunONE],[
+[  --with-nsapi=DIR        Build PHP as NSAPI module for
Netscape/iPlanet/Sun],[
   PHP_NSAPI=$withval
@@ -15,3 +15,3 @@
   if test ! -d $PHP_NSAPI/bin ; then
-    AC_MSG_ERROR(Please specify the path to the root of your
Netscape/iPlanet/SunONE server using --with-nsapi=DIR)
+    AC_MSG_ERROR(Please specify the path to the root of your
Netscape/iPlanet/Sun server using --with-nsapi=DIR)
   fi
@@ -19,5 +19,7 @@
   if test -d $PHP_NSAPI/include ; then
+    test -n "$NSAPI_INCLUDE" && NSAPI_INC_DIR="-I$NSAPI_INCLUDE"
     NSAPI_INCLUDE=$PHP_NSAPI/include
-    AC_MSG_RESULT(Netscape-Enterprise 3.x style)
+    AC_MSG_RESULT(Netscape 3.x style / Sun 7.x style)
     AC_CHECK_HEADERS([$NSAPI_INCLUDE/nsapi.h])
+    NSAPI_INCLUDE="$NSAPI_INC_DIR -I$NSAPI_INCLUDE"
   fi
@@ -26,3 +28,3 @@
     NSAPI_INCLUDE="$PHP_NSAPI/plugins/include"
-    AC_MSG_RESULT(iPlanet 4.x / SunONE 6.x style)
+    AC_MSG_RESULT(iPlanet 4.x / Sun 6.x style)
     AC_CHECK_HEADERS([$NSAPI_INCLUDE/nsapi.h])
@@ -36,3 +38,3 @@
   PHP_BUILD_THREAD_SAFE
-  AC_DEFINE(HAVE_NSAPI,1,[Whether you have a Netscape/iPlanet/SunONE
Server])
+  AC_DEFINE(HAVE_NSAPI,1,[Whether you have a Netscape/iPlanet/Sun
server])
   PHP_SELECT_SAPI(nsapi, shared, nsapi.c)

The critical change is to define NSAPI_INC_DIR.

The message changes are cosmetic and reflect that Sun Java System Web
Server 7.0 is now supported.

------------------------------------------------------------------------

[2006-10-19 20:39:47] ormandj at corenode dot com

I think the problem is somewhere in this code in "configure", as it
seems to be where it adds it to the "includes". If you have any idea
what I should do, I'll give it a try:

  for ac_i in $NSAPI_INCLUDE; do
    case $ac_i in
    -I*)
      ac_ii=`echo $ac_i|cut -c 3-`

  if test "$ac_ii" != "/usr/include"; then

  if test -z "$ac_ii" || echo "$ac_ii" | grep '^/' >/dev/null ; then
    ai_p=$ac_ii
  else

    ep_dir="`echo $ac_ii|$SED 's%/*[^/][^/]*/*$%%'`"

    ep_realdir="`(cd \"$ep_dir\" && pwd)`"
    ai_p="$ep_realdir/`basename \"$ac_ii\"`"
  fi



  unique=`echo $ai_p|$SED 's/[^a-zA-Z0-9]/_/g'`

  cmd="echo $ac_n \"\$INCLUDEPATH$unique$ac_c\""
  if test -n "$unique" && test "`eval $cmd`" = "" ; then
    eval "INCLUDEPATH$unique=set"

      if test ""; then
        INCLUDES="-I$ai_p $INCLUDES"
      else
        INCLUDES="$INCLUDES -I$ai_p"
      fi

  fi

  fi

    ;;
    esac
  done

------------------------------------------------------------------------

[2006-10-19 20:35:20] ormandj at corenode dot com

I would love to do that, but I'm not that good with "configure". I did
look in config.m4, but I don't know things well enough to fix it. If
you look in the output, configure *looks* like it detected nsapi.h
correctly. The problem is in the compile itself, it's not got
"-I/sun/webserver7/include" which is where nsapi.h resides.

As I said, I can give you an account with access to all of this to
determine the cause/provide a fix, I really do not know "configure". It
just needs to add that -I$NSAPI_INCLUDE to the compile. I can't see in
config.m4 where it does anything but define $NSAPI_INCLUDE, but that is
already defined correctly as /sun/webserver7/include. I think the error
lies elsewhere, maybe a hint?

------------------------------------------------------------------------

[2006-10-19 20:28:25] [EMAIL PROTECTED]

As I've said I don't use/have Sun webserver, so I can't test it (and
hence can't fix).
Fix sapi/nsapi/config.m4 and send me a patch, I'll gladly review it. 

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
    http://bugs.php.net/39192

-- 
Edit this bug report at http://bugs.php.net/?id=39192&edit=1

Reply via email to